-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine console logs pages #1034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine as it pretty much matches structured logs.
The monitoring pages show resources ordered alphabetically. The resources page orders them by type, then alphabetically. How do we feel about that consistency? |
I'm conflicted about it (don't like the inconsistency) but it was done on purpose: For the resources page, with the new columns whose data vary by type, grouping the rows by type helped visual scanning (imo at least) - when the columns with different data in them were intermingled it felt harder to scan them. For the monitoring pages, without any extra data to identify why they were not alphabetical (in other words no type column or icon) it felt more natural to be alphabetical. I'll readily admit these are subjective takes and am happy to tweak or take feedback. But that's why I went that way after fiddling with a few variants. |
f55d018
to
f1a5a7c
Compare
When you click on the console logs link in the menu, what decides which app to display? Structured logs and traces have an "All" option and select it by default. But that doesn't make sense for console logs. I think the console logs could do the same thing. That page would also be displayed if a bad name is in the url, e.g. |
Resolves #176
After #987, merging the logs pages is the next logical step.
Unlike #987, not much to show from a visuals perspective other than the changes to the menu structure:
Note: #176 had discussion of indicating the type of resource that is selected. For the moment, I've left that out of this PR and plan to do follow up once people take a look and we can agree on a design (icon in select? text in the header?).