Fix migrations service in playground #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can call If you remove the transaction you'll need to remove the execution strategy as well, since retrying in case of a failure will only make it worse. This is tracked in dotnet/efcore#22616 |
|
The retry is there to keep retrying until the database server container is running. Database creator worked and I've re-added the transaction. Please take another look. |
Comment on lines
+40
to
+53
| if (!await dbCreator.ExistsAsync(cancellationToken)) | ||
| { | ||
| await dbCreator.CreateAsync(cancellationToken); | ||
| } |
There was a problem hiding this comment.
I'd move these to a separate .ExecuteAsync call, since they could use up all retries while waiting for the container to start and if there's any delay creating the database BeginTransactionAsync will just fail without retrying.
AndriySvyryd
approved these changes
Feb 23, 2024
JamesNK
force-pushed
the
jamesnk/fix-migrations-service
branch
from
dc1ad0a
to
0e3afab
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2308
Creating a transaction failed if starting from a blank slate because there isn't a database to create a transaction on. Removing the transaction fixes this problem.
However, it would be ideal to keep the transaction to make this safe to transient errors. To follow best practice, we need to:
@AndriySvyryd How do you instruct EF to just create the database? I looked at
DbContext.Database.EnsureCreatedAsync, but it also creates tables.Microsoft Reviewers: Open in CodeFlow