Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OnAfterRenderAsync in ResourceLogsBase #415

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Use OnAfterRenderAsync in ResourceLogsBase #415

merged 1 commit into from
Oct 20, 2023

Conversation

tlmii
Copy link
Member

@tlmii tlmii commented Oct 20, 2023

After discussions with @SteveSandersonMS and @javiercn about async initialization of blazor components, making a switch to how the streaming logs pages perform their initial loading of data and the first call to LoadLogsAsync. Should be no functional change here, but if upcoming caching changes causes GetResources to not yield in some cases, this change should prevent a failure on first load.

@tlmii tlmii merged commit 681813b into dotnet:main Oct 20, 2023
4 checks passed
@tlmii tlmii deleted the dev/deterministic-load-logs branch October 20, 2023 14:08
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants