Rework dashboard layout #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
approved these changes
Oct 24, 2023
|
This change broke structured logs and traces pages. The entire page scrolls instead of just content in the grid. Before: After: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #449, fixes #397, fixes #346, prep for #454
We have many content pages in the site where we want a subset of the page to scroll, taking up "the rest" of the content pane beyond some headers/toolbars at the top. We also have upcoming work with a splitter and list/details panes. Both of these scenarios are more easily handled if the overall layout isn't intended to be scrollable beyond the viewport. So we switch to using a CSS grid layout as the root layout. Content pages are then free to choose what layout within the main area they want to use (fully scrollable, scrollable subsection, splitter, etc). The header and nav bar stay in place.
The Projects/Containers/Executables pages are also updated to use a grid layout in anticipation of the details view in #454. The logs pages are also updated to use a grid layout to remove the hackish way we were sizing the height of the log viewer. No changes were made to the Trace/Traces/StructuredLogs page layouts (yet).
This PR also makes the header icon/text a link back to
/We also updated the FluentUI Blazor components to 3.2.1, which brings in numerous accessibility fixes, among other things.
No screenshots, because hopefully most of this is transparent to the end user except in edge cases which were bugs anyway.