Fix formatting fails in the presence of a non-extensible directive #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aside from the Razor log does anything else break because of this? Aka, does the language server crash? |
No. It only shows up in the logs. |
Awesome, good to know! |
ajaybhargavb
added a commit
that referenced
this pull request
Mar 6, 2020
ajaybhargavb
added a commit
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/aspnetcore#19609
We get a null-ref in cases of non-extensible directives like
@usingwhich don't have a DirectiveDescriptor attached to them.