Skip to content

Commit

Permalink
Update Microsoft.AspNetCore.Components.WebView.csproj (#52973)
Browse files Browse the repository at this point in the history
Backport of #52638 to release/6.0

/cc @MackinnonBuck

# Fix `Microsoft.AspNetCore.Components.WebView.props` not getting packed correctly

Fixes an issue where `Microsoft.AspNetCore.Components.WebView.props` was not getting packed correctly. This was causing build failures for any project referencing `Microsoft.AspNetCore.Components.WebView`.

## Description

Fixes #52637

## Customer Impact

If customers were to reference a new version of this package without this fix, their app would fail to build. Our temporary workaround is to avoid shipping new versions of `Microsoft.AspNetCore.Components.WebView` until this issue gets fixed.

## Regression?

- [X] Yes
- [ ] No

Regressed from package version 6.0.25.

## Risk

- [ ] High
- [ ] Medium
- [X] Low

The fix is straightforward, and we've verified that the packages produced in CI contain the correct assets. A [MAUI dependency update](dotnet/maui#19236) was failing due to this bug, and the fix has shown to address it.

## Verification

- [X] Manual (required)
- [ ] Automated

## Packaging changes reviewed?

- [ ] Yes
- [ ] No
- [X] N/A


Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
  • Loading branch information
github-actions[bot] and MackinnonBuck authored Jan 16, 2024
1 parent 34979a4 commit fb79f3e
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@

<ItemGroup>
<None Include="buildTransitive\Microsoft.AspNetCore.Components.WebView.props" Pack="true" PackagePath="%(Identity)" />
<None Include="buildMultiTargeting\Microsoft.AspNetCore.Components.WebView.props" Pack="true" PackagePath="%(Identity)" />
<None Include="build\Microsoft.AspNetCore.Components.WebView.props" Pack="true" PackagePath="%(Identity)" />
</ItemGroup>

<ItemGroup>
Expand Down

0 comments on commit fb79f3e

Please sign in to comment.