Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log when we see an OPTIONS without AccessControlRequestMethod #2375

Closed
aspnet-hello opened this issue Jan 1, 2018 · 0 comments
Closed

Log when we see an OPTIONS without AccessControlRequestMethod #2375

aspnet-hello opened this issue Jan 1, 2018 · 0 comments
Assignees
@pranavkm
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed task
Milestone
2.2.0-preview3

Comments

@aspnet-hello
Copy link

From @rynowak on Wednesday, June 14, 2017 1:31:11 PM

Right here, we ignore an OPTIONS request without the AccessControlRequestMethod header, and treat it as a non-preflight request.

We should log specifically when this happens, it's important to know why in this case the request is being treated as non-preflight.

What will typically happen is that your CORS-ing in front of an API, and that API won't support OPTIONS, so you get a 404.

Copied from original issue: aspnet/CORS#113
@aspnet-hello aspnet-hello added this to the 2.1.0-preview1 milestone Jan 1, 2018
@aspnet-hello aspnet-hello mentioned this issue Jan 1, 2018
Closed
@mkArtakMSFT mkArtakMSFT modified the milestones: 2.1.0-preview1, 2.2.0 Jan 17, 2018
pranavkm added a commit to aspnet/CORS that referenced this issue Oct 11, 2018
@pranavkm
Log when a request is an OPTIONS request but not a preflight request
fb649d4 
Fixes dotnet/aspnetcore#2375
pranavkm added a commit to aspnet/CORS that referenced this issue Oct 11, 2018
@pranavkm
Log when a request is an OPTIONS request but not a preflight request
1b7e95c 
Fixes dotnet/aspnetcore#2375
@pranavkm pranavkm mentioned this issue Oct 11, 2018
Merged
pranavkm added a commit to aspnet/CORS that referenced this issue Oct 11, 2018
@pranavkm
Log when a request is an OPTIONS request but not a preflight request
a4079ad 
Fixes dotnet/aspnetcore#2375
pranavkm added a commit to aspnet/CORS that referenced this issue Oct 11, 2018
@pranavkm
Log when a request is an OPTIONS request but not a preflight request
e6bdf12 
Fixes dotnet/aspnetcore#2375
@pranavkm pranavkm added Done This issue has been fixed and removed 2 - Working labels Oct 11, 2018
@Eilon Eilon added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates and removed repo:CORS labels Nov 26, 2018
ryanbrandenburg pushed a commit that referenced this issue Nov 27, 2018
@DylanDmitri
ping timeout changes (#2375)
e3835b3 
documentation updates
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed task
Projects
None yet
Milestone
2.2.0-preview3
Development

No branches or pull requests
4 participants
@pranavkm @Eilon @mkArtakMSFT @aspnet-hello