Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call AddOptions() from Configure/AddOptions #2383

Closed
aspnet-hello opened this issue Jan 1, 2018 · 0 comments
Closed

Call AddOptions() from Configure/AddOptions #2383

aspnet-hello opened this issue Jan 1, 2018 · 0 comments
Assignees
@HaoK
Labels
bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
2.1.0-preview1

Comments

@aspnet-hello
Copy link

From @HaoK on Tuesday, November 21, 2017 12:14:15 PM

Copied from original issue: aspnet/Options#243
@aspnet-hello aspnet-hello added this to the 2.1 milestone Jan 1, 2018
@aspnet-hello aspnet-hello added bug This issue describes a behavior which is not expected - a bug. repo:Options labels Jan 1, 2018
@aspnet-hello aspnet-hello mentioned this issue Jan 1, 2018
Closed
@Eilon Eilon modified the milestones: 2.1, 2.1.0 Jan 10, 2018
@HaoK HaoK mentioned this issue Jan 16, 2018
Merged
@HaoK HaoK added Done This issue has been fixed and removed 2 - Working labels Jan 19, 2018
@HaoK HaoK modified the milestones: 2.1.0, 2.1.0-preview1 Jan 19, 2018
natemcmaster pushed a commit that referenced this issue Nov 14, 2018
@davidfowl
Feature/clean up proto abstractions (#2383)
2d8f3d9 
- This change aims to clean up the feature interfaces
 used by kestrel and exposed by protocol absractions. It splits out the
 IConnectionTransportFeature into smaller features that may or may
 not be implemented on the connection.
- Added all of the features from Socket.Abstractions
in an attempt to make it go away completely. As a result
the helper methods and extensions have all been added here.
- Change IConnectionHandler to take TransportConnection. This cleans up the interface and makes it more explicit what features are required by Kestrel
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HaoK HaoK

Labels
bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
2.1.0-preview1
Development

No branches or pull requests
3 participants
@Eilon @HaoK @aspnet-hello