Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for C#'s "Fully qualify" light bulb in C# sections of a Razor file in VS #5226

Closed
NTaylorMullen opened this issue Aug 11, 2020 · 1 comment · Fixed by #2501
Closed

Add support for C#'s "Fully qualify" light bulb in C# sections of a Razor file in VS #5226

NTaylorMullen opened this issue Aug 11, 2020 · 1 comment · Fixed by #2501
Assignees
@TanayParikh
Milestone
16.8-Preview4

Comments

@NTaylorMullen
Copy link
Contributor

The idea behind this issue is to enable users to ctrl + . -> fully qualify a piece of C# that is not properly included.
@TanayParikh
Copy link
Contributor

Blocked on: https://github.com/dotnet/aspnetcore/issues/25250

Prioritizing that and other tasks, pushing this to preview 4.

TanayParikh referenced this issue Sep 16, 2020
@TanayParikh
Support CSharp Light Bulbs (FQN, Add Using) (#2501)
66dbb85 
### Summary of the changes

- Support for Fully Qualified Namespace C# Light Bulb
![FullyQualifiedCodeAction](https://user-images.githubusercontent.com/14852843/93262976-f1da7f80-f759-11ea-9877-05e9df2ed88b.gif)

- Support for Add Using C# Light bulb
![AddUsingCodeAction](https://user-images.githubusercontent.com/14852843/93263130-2d754980-f75a-11ea-890d-bfb07516a354.gif)

- Abstraction Layer / Refactoring to create shared light bulb infrastructure between TSLanguageServer + HTMLCSharpLanguageServer.
- This implementation doesn't have support for code actions which require resolving with Roslyn (ex. via `textDocument/codeActionResolve`). Working on an appropriate expansion for this, and will likely require changes in `omnisharp-vscode`.
    - Tracked here: https://github.com/dotnet/aspnetcore/issues/25918
- Some general perf optimizations are possible, but wanted to avoid potential pre-optimizations. Will re-visit if we see issues.
- Testing: TODO assuming no issues with the design.

Fixes: https://github.com/dotnet/aspnetcore/issues/24779
Fixes: https://github.com/dotnet/aspnetcore/issues/18173
Fixes: https://github.com/dotnet/aspnetcore/issues/24778
Fixes: https://github.com/dotnet/aspnetcore/issues/25144
@ghost ghost locked as resolved and limited conversation to collaborators Oct 16, 2020
@ghost ghost unlocked this conversation Oct 9, 2021
@allisonchou allisonchou transferred this issue from dotnet/aspnetcore Oct 9, 2021
@allisonchou allisonchou added this to the 16.8-Preview4 milestone Oct 9, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TanayParikh TanayParikh

Labels
None yet
Projects
None yet
Milestone
16.8-Preview4
Development

Successfully merging a pull request may close this issue.

Support CSharp Light Bulbs (FQN, Add Using) dotnet/razor
3 participants
@NTaylorMullen @TanayParikh @allisonchou