Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarantine CanRenderComponentWithPersistedState(suppressEnhancedNavigation: False, renderMode: typeof(Microsoft.AspNetCore.Components.Web.InteractiveAutoRenderMode), streaming: "AutoStreaming"/null) #50810

Closed
SteveSandersonMS opened this issue Sep 19, 2023 · 6 comments · Fixed by #55603
Assignees
Labels
area-blazor Includes: Blazor, Razor Components investigate Pillar: Technical Debt Priority:0 Work that we can't release without test-failure
Milestone

Comments

@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Sep 19, 2023

Failing Test(s)

  • Microsoft.AspNetCore.Components.E2ETests.Tests.StatePersistenceTest.CanRenderComponentWithPersistedState

... but only the following variants:

[InlineData(true, typeof(InteractiveAutoRenderMode), (string)null)]
[InlineData(false, typeof(InteractiveAutoRenderMode), (string)null)]
[InlineData(false, typeof(InteractiveAutoRenderMode), "AutoStreaming")]

We need to verify this is not a product bug before 8.0 ships, so putting it in the 8.0 milestone.

Error Message

Xunit.Sdk.EqualException: Assert.Equal() Failure
Expected: Interactive runtime: server
Actual:   Interactive runtime: wasm

Stacktrace

   at Microsoft.AspNetCore.E2ETesting.WaitAssert.WaitAssertCore[TResult](IWebDriver driver, Func`1 assertion, TimeSpan timeout) in /home/vsts/work/1/s/src/Shared/E2ETesting/WaitAssert.cs:line 129
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.WaitAssertCore(IWebDriver driver, Action assertion, TimeSpan timeout) in /home/vsts/work/1/s/src/Shared/E2ETesting/WaitAssert.cs:line 83
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.Equal[T](IWebDriver driver, T expected, Func`1 actual) in /home/vsts/work/1/s/src/Shared/E2ETesting/WaitAssert.cs:line 27
   at Microsoft.AspNetCore.Components.E2ETests.Tests.StatePersistenceTest.AssertPageState(String mode, String renderMode, Boolean interactive, Boolean stateFound, String stateValue, String streamingId, Boolean streamingCompleted, String interactiveRuntime) in /home/vsts/work/1/s/src/Components/test/E2ETest/Tests/StatePersistenceTest.cs:line 225
   at Microsoft.AspNetCore.Components.E2ETests.Tests.StatePersistenceTest.RenderComponentsWithPersistentStateAndValidate(Boolean suppresEnhancedNavigation, String mode, Type renderMode, String streaming, String interactiveRuntime, String stateValue) in /home/vsts/work/1/s/src/Components/test/E2ETest/Tests/StatePersistenceTest.cs:line 197
   at Microsoft.AspNetCore.Components.E2ETests.Tests.StatePersistenceTest.CanRenderComponentWithPersistedState(Boolean suppressEnhancedNavigation, Type renderMode, String streaming) in /home/vsts/work/1/s/src/Components/test/E2ETest/Tests/StatePersistenceTest.cs:line 101
   at InvokeStub_StatePersistenceTest.CanRenderComponentWithPersistedState(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
----- Inner Stack Trace -----
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.<>c__DisplayClass18_0`1.<WaitAssertCore>b__0(IWebDriver _) in /home/vsts/work/1/s/src/Shared/E2ETesting/WaitAssert.cs:line 101

Logs


Build

https://dev.azure.com/dnceng-public/public/_build/results?buildId=411184
https://dev.azure.com/dnceng-public/public/_build/results?buildId=411665
https://dev.azure.com/dnceng-public/public/_build/results?buildId=457395

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Sep 19, 2023
@SteveSandersonMS SteveSandersonMS added this to the 8.0 milestone Sep 19, 2023
@SteveSandersonMS
Copy link
Member Author

SteveSandersonMS commented Sep 19, 2023

Note that since these are [InlineData] cases, they can't be quarantined in the normal way. So instead I've commented out those lines. They will not get unquarantined automatically. The person resolving this issue needs to uncomment them to bring them back.

@SteveSandersonMS SteveSandersonMS changed the title Quarantine CanRenderComponentWithPersistedState(suppressEnhancedNavigation: False, renderMode: typeof(Microsoft.AspNetCore.Components.Web.InteractiveAutoRenderMode), streaming: "AutoStreaming") Quarantine CanRenderComponentWithPersistedState(suppressEnhancedNavigation: False, renderMode: typeof(Microsoft.AspNetCore.Components.Web.InteractiveAutoRenderMode), streaming: "AutoStreaming"/null) Sep 19, 2023
wtgodbe pushed a commit that referenced this issue Sep 20, 2023
SteveSandersonMS added a commit that referenced this issue Sep 20, 2023
…ed navigating away (#50814)

* Reproduce #50733 as a failing E2E test

* Don't process original request blazor-ssr content if the user has already navigated away

* Quarantine (actually comment out) one of the CanRenderComponentWithPersistedState cases

See #50810

* Update EventTest.cs

* Disable another flaky test
dotnet-maestro bot added a commit that referenced this issue Sep 20, 2023
[release/8.0] Update dependencies from dotnet/arcade


 - Update EventTest.cs now that Selenium reports the full set of events properly

 - Update EventTest.cs

 - Quarantine (actually comment out) one of the CanRenderComponentWithPersistedState cases

See #50810

 - Disable another flaky test
javiercn pushed a commit that referenced this issue Sep 20, 2023
[release/8.0] Update dependencies from dotnet/arcade


 - Update EventTest.cs now that Selenium reports the full set of events properly

 - Update EventTest.cs

 - Quarantine (actually comment out) one of the CanRenderComponentWithPersistedState cases

See #50810

 - Disable another flaky test
SteveSandersonMS added a commit that referenced this issue Sep 20, 2023
* Handle obsolete InterceptorsPreview with .NET 8 RC2 SDK (#50797)

* Quarantine (actually comment out) one of the CanRenderComponentWithPersistedState cases (#50811)

See #50810

* Stop processing original response streaming content if user has started navigating away (#50814)

* Reproduce #50733 as a failing E2E test

* Don't process original request blazor-ssr content if the user has already navigated away

* Quarantine (actually comment out) one of the CanRenderComponentWithPersistedState cases

See #50810

* Update EventTest.cs

* Disable another flaky test

---------

Co-authored-by: Matt Thalman <mthalman@microsoft.com>
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
SteveSandersonMS pushed a commit to dotnet-maestro-bot/AspNetCore that referenced this issue Sep 20, 2023
[release/8.0] Update dependencies from dotnet/arcade


 - Update EventTest.cs now that Selenium reports the full set of events properly

 - Update EventTest.cs

 - Quarantine (actually comment out) one of the CanRenderComponentWithPersistedState cases

See dotnet#50810

 - Disable another flaky test
SteveSandersonMS added a commit to dotnet-maestro-bot/AspNetCore that referenced this issue Sep 20, 2023
…0823)

* Handle obsolete InterceptorsPreview with .NET 8 RC2 SDK (dotnet#50797)

* Quarantine (actually comment out) one of the CanRenderComponentWithPersistedState cases (dotnet#50811)

See dotnet#50810

* Stop processing original response streaming content if user has started navigating away (dotnet#50814)

* Reproduce dotnet#50733 as a failing E2E test

* Don't process original request blazor-ssr content if the user has already navigated away

* Quarantine (actually comment out) one of the CanRenderComponentWithPersistedState cases

See dotnet#50810

* Update EventTest.cs

* Disable another flaky test

---------

Co-authored-by: Matt Thalman <mthalman@microsoft.com>
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
@wtgodbe wtgodbe modified the milestones: 8.0, 8.0.0 Oct 3, 2023
@mkArtakMSFT mkArtakMSFT modified the milestones: 8.0.0, .NET 9 Planning Oct 4, 2023
@ghost
Copy link

ghost commented Oct 4, 2023

Thanks for contacting us.

We're moving this issue to the .NET 9 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost
Copy link

ghost commented Oct 10, 2023

To learn more about what this message means, what to expect next, and how this issue will be handled you can read our Triage Process document.
We're moving this issue to the .NET 9 Planning milestone for future evaluation / consideration. Because it's not immediately obvious what is causing this behavior, we would like to keep this around to collect more feedback, which can later help us determine how to handle this. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact work.

@amcasey
Copy link
Member

amcasey commented Nov 6, 2023

Saw a new failure in Microsoft.AspNetCore.Components.E2ETests.Tests.StatePersistenceTest.CanRenderComponentWithPersistedState(suppressEnhancedNavigation: True, renderMode: typeof(Microsoft.AspNetCore.Components.Web.InteractiveAutoRenderMode), streaming: "AutoStreaming")​

OpenQA.Selenium.BrowserAssertFailedException : Xunit.Sdk.EqualException: Assert.Equal() Failure
Expected: Interactive runtime: wasm
Actual:   Interactive runtime: server

@BrennanConroy
Copy link
Member

And Microsoft.AspNetCore.Components.E2ETests.Tests.StatePersistenceTest.CanRenderComponentWithPersistedState(suppressEnhancedNavigation: True, renderMode: typeof(Microsoft.AspNetCore.Components.Web.InteractiveAutoRenderMode), streaming: null) in https://dev.azure.com/dnceng-public/public/_build/results?buildId=482738&view=ms.vss-test-web.build-test-results-tab&runId=11110162&resultId=101127&paneView=debug

@ghost
Copy link

ghost commented Dec 14, 2023

To learn more about what this message means, what to expect next, and how this issue will be handled you can read our Triage Process document.
We're moving this issue to the .NET 9 Planning milestone for future evaluation / consideration. Because it's not immediately obvious what is causing this behavior, we would like to keep this around to collect more feedback, which can later help us determine how to handle this. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact work.

@mkArtakMSFT mkArtakMSFT added the Priority:0 Work that we can't release without label Jan 3, 2024
3dots pushed a commit to 3dots/aspnetcore-Web.JS that referenced this issue Feb 19, 2024
…ed navigating away (#50814)

* Reproduce #50733 as a failing E2E test

* Don't process original request blazor-ssr content if the user has already navigated away

* Quarantine (actually comment out) one of the CanRenderComponentWithPersistedState cases

See dotnet/aspnetcore#50810

* Update EventTest.cs

* Disable another flaky test
3dots pushed a commit to 3dots/aspnetcore-Web.JS that referenced this issue Feb 19, 2024
* Handle obsolete InterceptorsPreview with .NET 8 RC2 SDK (#50797)

* Quarantine (actually comment out) one of the CanRenderComponentWithPersistedState cases (#50811)

See dotnet/aspnetcore#50810

* Stop processing original response streaming content if user has started navigating away (#50814)

* Reproduce #50733 as a failing E2E test

* Don't process original request blazor-ssr content if the user has already navigated away

* Quarantine (actually comment out) one of the CanRenderComponentWithPersistedState cases

See dotnet/aspnetcore#50810

* Update EventTest.cs

* Disable another flaky test

---------

Co-authored-by: Matt Thalman <mthalman@microsoft.com>
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
@halter73 halter73 modified the milestones: 9.0-preview3, 9.0-preview4 Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components investigate Pillar: Technical Debt Priority:0 Work that we can't release without test-failure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants