Blazor [SupplyParameterFromQuery] not usable in OnInitialized() when navigating [dotnet 8.rc2] #51398

ipax77 · 2023-10-16T05:58:54Z

Is there an existing issue for this?

I have searched the existing issues #51586

Describe the bug

When adding multiple Query strings to a Blazor page they cannot be consumed.

    [SupplyParameterFromQuery]
    public string? Test1 { get; set; }

    [SupplyParameterFromQuery]
    public string? Test2 { get; set; }

At OnInitialized the parameters are null.
At OnParametersSet they are set

When consuming the parameters in a SubComponent only one Parameter is set / consumable.

Reloading the page and navigating

    void Navigate()
    {
        NavigationManager.NavigateTo(NavigationManager.GetUriWithQueryParameters("counter",
            new Dictionary<string, object?>()
                    {
                    {"Test1", "Summer" },
                    {"Test2", "Winter" },
                    }
        ));
    }

produce different results, but never all parameters are sets.

Navigate result:

SupplyParameterFromQuery Test1: Summer
SupplyParameterFromQuery Test2: Winter
OnParametersSet Test1: Summer
OnParametersSet Test2: Winter

OnInitialized Test1:
OnInitialized Test2:

OnParametersSet TestComponent:
Test1: Summer
Test2: Winter

OnParametersSet snapshot
Test1: Summer
Test2:
OnInitialized snapshot
Test1:
Test2: Winter

OnInitialized TestComponent
Test1:
Test2:
OnParametersSet snapshot
Test1:
Test2:
OnInitialized snapshot
Test1:
Test2:

Reload result:

SupplyParameterFromQuery Test1: Summer
SupplyParameterFromQuery Test2: Winter
OnParametersSet Test1: Summer
OnParametersSet Test2: Winter
OnInitialized Test1: Summer
OnInitialized Test2: Winter

OnParametersSet TestComponent
Test1: Summer
Test2: Winter

OnParametersSet snapshot
Test1: Summer
Test2:
OnInitialized snapshot
Test1: Summer
Test2: Winter

OnInitialized TestComponent
Test1: Summer
Test2: Winter

OnParametersSet snapshot
Test1: Summer
Test2:
OnInitialized snapshot
Test1: Summer
Test2: Winter

Expected Behavior

The parameters should be consumable at/after page load (e.g. to use them for database requests)

Steps To Reproduce

SampleProject Click on 'Navigate' and reload the page with the parameters.

   [SupplyParameterFromQuery]
    public string? Test1 { get; set; }

    [SupplyParameterFromQuery]
    public string? Test2 { get; set; }

    TestRecord testRecord1 = new();
    TestRecord testRecord2 = new();

    protected override void OnParametersSet()
    {
        SetParameters1();
        base.OnParametersSet();
    }

    protected override void OnInitialized()
    {
        SetParameters2();
        base.OnInitialized();
    }

    void SetParameters1()
    {
        testRecord1.Test1 = Test1;
        testRecord1.Test2 = Test2;
    }

    void SetParameters2()
    {
        testRecord2.Test1 = Test1;
        testRecord2.Test2 = Test2;
    }

Exceptions (if any)

No response

.NET Version

8.0.100-rc.2.23502.2

Anything else?

Sample and test with Blazor wasm

The text was updated successfully, but these errors were encountered:

kapryeong · 2023-10-17T08:15:23Z

It is also incorrect within the OnInitializedAsync method. (RC2) (ServerRenderMode)
Weather.razor

<h1>Befor Task.Delay : @_beforName</h1>
<h1>After Task.Delay : @_afterName</h1>
<h1>@Name</h1>
@code {
    [SupplyParameterFromQuery]
    public string Name { get; set; }

    private string _beforName;
    private string _afterName;

    protected override async Task OnInitializedAsync()
    {
        _beforName = Name;        
        // Simulate asynchronous loading to demonstrate a loading indicator
        await Task.Delay(500);
        _afterName = Name;
    }

surayya-MS · 2023-10-18T09:08:16Z

I tried it out and got the same result - [SupplyParameterFromQuery] doesn't work in OnInitialized() when navigating but works when the page is refreshed

mkArtakMSFT · 2023-10-23T16:06:42Z

@ipax77 do you know if this is something you're experienced only in some rendering mode but not others?

ipax77 · 2023-10-23T19:21:47Z

@mkArtakMSFT the original test was on a Blazor wasm project.
I added a blazor sample project with both render modes: SampleProject
The results are inconsistent no matter from (Home (Server), Counter(Wasm)) or the to render mode. But it seems that in the blazor auto project either both parameters are set or both not. While on blazor wasm sometimes one or the other is set.

Parameters: Test1: Summer, Test2: Winter
OnParametersSetAsync: Test1: Summer, Test2: Winter
OnParametersSet: Test1: Summer, Test2: Winter
OnInitializedAsync: Test1: Summer, Test2: Winter
OnInitialized: Test1: Summer, Test2: Winter

Parameters: Test1: , Test2:
OnParametersSetAsync: Test1: , Test2:
OnParametersSet: Test1: , Test2:
OnInitializedAsync: Test1: , Test2:
OnInitialized: Test1: , Test2:

vindberg · 2023-10-23T20:29:41Z

Is there any way we can get this bug prioritized higher by the team or @SteveSandersonMS or @surayya-MS. It's a showstopper for our upgrade of watchpedia.com

akpatternica · 2023-10-24T08:23:36Z

so blazor in 8.0 will be completly unusable:(

surayya-MS · 2023-10-24T13:24:10Z

This has been addressed by this PR #51279

oliverw · 2023-11-11T11:05:43Z

This has been addressed by this PR #51279

Well, the fix does not work if you are using a non-interactive router in the server project.

oliverw · 2023-11-11T11:07:29Z

so blazor in 8.0 will be completly unusable:(

Maybe not unusable, but combined with the state management problem that is also not going to be addressed, it seriously degrades the experience.

seth-tc · 2023-12-11T22:14:55Z

Can confirm this issue exists in dotnet 8.0.100. Parameters provided via [SupplyParameterFromQuery] cannot be used in OnInitialized(Async) at all. They are NOT set on the component prior to OnInitialized being called. From the lifecycle docs here (https://learn.microsoft.com/en-us/aspnet/core/blazor/components/lifecycle?view=aspnetcore-8.0#when-parameters-are-set-setparametersasync):

"OnInitialized and OnInitializedAsync are invoked when the component is initialized after having received its initial parameters in SetParametersAsync."

This was true in dotnet 7 (I am considered URL query string parameters to be "Initial parameters") but is not working for me in dotnet 8. I could not find any solution other than to manually parse out the parameters inside OnInitialized(Async) where needed.

The parameters are eventually set, but they are set in a second call to SetParametersAsync which occurs after OnInitialized(Async).

c4l3b · 2023-12-22T06:42:32Z

+1 confirming this is broken in 8.0.100. I'm using InteractiveWebAssemblyRenderMode with prerender:false.
When navigating from another page, the query params are not set. When refreshing the page, they are set.

milkyjoe90 · 2024-01-20T16:21:24Z

I'm also experiencing this issue in 8.0 and 8.0.1, have reverted back to 7 in order to continue developing.

agilealtitude · 2024-01-23T16:43:58Z

Back to 7 I go, too. You would think this particular issue would have been tested and identified...

danm-de · 2024-03-06T10:03:26Z

@surayya-MS is there a way we can re-open this bug report? As of today, using .NET 8.0.200 with Blazor ServerApp we experience the same problem.

The properties marked with [SupplyParameterFromQuery] are not set correctly during OnInitialize / OnInitializeAsync.

Our users expect deep linking to work, so we use the OnInitializeAsync method to perform a database query with the desired filter conditions. The results have been incorrect since we switched to .NET8 because the values in the query parameters are not correctly transferred to the marked properties.

Related: #53055

milkyjoe90 · 2024-03-06T18:23:19Z

It's been added to the 8.0.3 release, haven't seen any expected timelines sadly. I've stuck with 7 up to this point, once this is fixed I'll be able to upgrade to 8 (barring any other issues that testing hasn't found yet)

https://github.com/dotnet/aspnetcore/milestone/303?closed=1

danm-de · 2024-03-20T13:19:04Z

I can confirm that it works again with 8.0.3 🎆 👍

agilealtitude · 2024-03-20T15:35:04Z

Thanks for updating us :) I still don't understand how there was not more of an outcry from devs, like me, attempting to upgrade their Blazor project to .Net 8... This issue was a show stopper...

milkyjoe90 · 2024-03-20T16:35:02Z

I can also confirm this is working, the 8.0.3 release has allowed me to upgrade from dot net 7 up to 8 in production now.

JimGorman17 · 2024-04-10T01:04:25Z

Can confirm this issue exists in dotnet 8.0.100. Parameters provided via [SupplyParameterFromQuery] cannot be used in OnInitialized(Async) at all. They are NOT set on the component prior to OnInitialized being called. From the lifecycle docs here (https://learn.microsoft.com/en-us/aspnet/core/blazor/components/lifecycle?view=aspnetcore-8.0#when-parameters-are-set-setparametersasync):

"OnInitialized and OnInitializedAsync are invoked when the component is initialized after having received its initial parameters in SetParametersAsync."

This was true in dotnet 7 (I am considered URL query string parameters to be "Initial parameters") but is not working for me in dotnet 8. I could not find any solution other than to manually parse out the parameters inside OnInitialized(Async) where needed.

The parameters are eventually set, but they are set in a second call to SetParametersAsync which occurs after OnInitialized(Async).

Correct. Why is this issue closed and marked as fixed? Still broken with 8.0.3.

milkyjoe90 · 2024-04-10T07:52:12Z

This issue was confirmed fixed for me in the 8.0.3 release, and in limited testing, appears not to have regressed and still work fine for me in 8.0.4. I’ll do more testing locally of 8.0.4 when I’m back at my desk properly tomorrow

dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Oct 16, 2023

mkArtakMSFT assigned surayya-MS Oct 16, 2023

mkArtakMSFT added the investigate label Oct 16, 2023

mkArtakMSFT added this to the 8.0.0 milestone Oct 16, 2023

surayya-MS changed the title ~~Blazor SupplyParameterFromQuery Routing not usable [dotnet 8.rc2]~~ Blazor SupplyParameterFromQuery not usable OnInitialized() [dotnet 8.rc2] Oct 18, 2023

surayya-MS changed the title ~~Blazor SupplyParameterFromQuery not usable OnInitialized() [dotnet 8.rc2]~~ Blazor [SupplyParameterFromQuery] not usable in OnInitialized() on navigation [dotnet 8.rc2] Oct 18, 2023

surayya-MS changed the title ~~Blazor [SupplyParameterFromQuery] not usable in OnInitialized() on navigation [dotnet 8.rc2]~~ Blazor [SupplyParameterFromQuery] not usable in OnInitialized() when navigating [dotnet 8.rc2] Oct 18, 2023

surayya-MS added bug This issue describes a behavior which is not expected - a bug. and removed investigate labels Oct 18, 2023

mkArtakMSFT modified the milestones: 8.0.0, 8.0.x Oct 23, 2023

surayya-MS closed this as completed Oct 24, 2023

surayya-MS removed their assignment Oct 24, 2023

surayya-MS removed this from the 8.0.x milestone Oct 24, 2023

hakenr mentioned this issue Jan 10, 2024

[SupplyParameterFromQuery] property not being set during OnInitializedAsync #53055

Closed

1 task

GinoCanessa added a commit to GinoCanessa/fhir-candle that referenced this issue Jan 10, 2024

Reverted to .Net 7.0, see dotnet/aspnetcore#51398

ad73929

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Blazor [SupplyParameterFromQuery] not usable in OnInitialized() when navigating [dotnet 8.rc2] #51398

Blazor [SupplyParameterFromQuery] not usable in OnInitialized() when navigating [dotnet 8.rc2] #51398

ipax77 commented Oct 16, 2023 •

edited by mkArtakMSFT

kapryeong commented Oct 17, 2023 •

edited

surayya-MS commented Oct 18, 2023 •

edited

mkArtakMSFT commented Oct 23, 2023

ipax77 commented Oct 23, 2023

vindberg commented Oct 23, 2023

akpatternica commented Oct 24, 2023

surayya-MS commented Oct 24, 2023

oliverw commented Nov 11, 2023 •

edited

oliverw commented Nov 11, 2023

seth-tc commented Dec 11, 2023

c4l3b commented Dec 22, 2023

milkyjoe90 commented Jan 20, 2024

agilealtitude commented Jan 23, 2024

danm-de commented Mar 6, 2024 •

edited

milkyjoe90 commented Mar 6, 2024

danm-de commented Mar 20, 2024

agilealtitude commented Mar 20, 2024

milkyjoe90 commented Mar 20, 2024

JimGorman17 commented Apr 10, 2024

milkyjoe90 commented Apr 10, 2024

Blazor [SupplyParameterFromQuery] not usable in OnInitialized() when navigating [dotnet 8.rc2] #51398

Blazor [SupplyParameterFromQuery] not usable in OnInitialized() when navigating [dotnet 8.rc2] #51398

Comments

ipax77 commented Oct 16, 2023 • edited by mkArtakMSFT

Is there an existing issue for this?

Describe the bug

Expected Behavior

Steps To Reproduce

Exceptions (if any)

.NET Version

Anything else?

kapryeong commented Oct 17, 2023 • edited

surayya-MS commented Oct 18, 2023 • edited

mkArtakMSFT commented Oct 23, 2023

ipax77 commented Oct 23, 2023

vindberg commented Oct 23, 2023

akpatternica commented Oct 24, 2023

surayya-MS commented Oct 24, 2023

oliverw commented Nov 11, 2023 • edited

oliverw commented Nov 11, 2023

seth-tc commented Dec 11, 2023

c4l3b commented Dec 22, 2023

milkyjoe90 commented Jan 20, 2024

agilealtitude commented Jan 23, 2024

danm-de commented Mar 6, 2024 • edited

milkyjoe90 commented Mar 6, 2024

danm-de commented Mar 20, 2024

agilealtitude commented Mar 20, 2024

milkyjoe90 commented Mar 20, 2024

JimGorman17 commented Apr 10, 2024

milkyjoe90 commented Apr 10, 2024

ipax77 commented Oct 16, 2023 •

edited by mkArtakMSFT

kapryeong commented Oct 17, 2023 •

edited

surayya-MS commented Oct 18, 2023 •

edited

oliverw commented Nov 11, 2023 •

edited

danm-de commented Mar 6, 2024 •

edited