Kestrel HttpClient Http2 interop tests #11869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
force-pushed
the
tratcher/interop2
branch
2 times, most recently
from
390bcea
to
0d2c847
Compare
Tratcher
force-pushed
the
tratcher/interop2
branch
2 times, most recently
from
0023e66
to
a7c71aa
Compare
jkotalik
reviewed
Jul 15, 2019
src/Servers/Kestrel/test/Interop.FunctionalTests/H2SpecTests.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/test/Interop.FunctionalTests/HttpClientHttp2InteropTests.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/test/Interop.FunctionalTests/HttpClientHttp2InteropTests.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/test/Interop.FunctionalTests/HttpClientHttp2InteropTests.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/test/Interop.FunctionalTests/HttpClientHttp2InteropTests.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/test/Interop.FunctionalTests/HttpClientHttp2InteropTests.cs
Show resolved
Hide resolved
halter73
reviewed
Jul 17, 2019
src/Servers/Kestrel/test/Interop.FunctionalTests/HttpClientHttp2InteropTests.cs
Show resolved
Hide resolved
halter73
reviewed
Jul 17, 2019
| var response = await responseTask; | ||
|
|
||
| Assert.Equal(HttpVersion.Version20, response.Version); | ||
| var stream = await response.Content.ReadAsStreamAsync(); |
There was a problem hiding this comment.
We should probably be putting DefaultTimeout() on all awaits in the main test method to be safe. I know it's annoying, but I think that should include stuff like HostBuilder.StartAsync() too.
halter73
approved these changes
Jul 17, 2019
jkotalik
approved these changes
Jul 17, 2019
analogrelay
added
the
tell-mode
Tratcher
force-pushed
the
tratcher/interop2
branch
from
bdb5415
to
d1b4548
Compare
ghost
deleted the
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4763 (comment) Incremental progress
Found a low priority client bug in bidirectional streaming: https://github.com/dotnet/corefx/issues/39404