Make some pubternal types in data protection #12121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make CngAuthenticatedEncryptorBase internal - Left IActivator public because they are used in constructors the XmlKeyManager ctor
davidfowl
force-pushed
the
davidfowl/remove-more-pubternal
branch
from
ade725a
to
5c8d503
Compare
|
Can I get an approval here. |
analogrelay
reviewed
Jul 13, 2019
| @@ -86,7 +86,7 @@ public void Decrypt_HandlesEmptyCiphertextPointerFixup() | |||
| Assert.Equal(new byte[] { 0x20, 0x21, 0x22 }, retVal); | |||
| } | |||
|
|
|||
| public abstract class MockableEncryptor : CngAuthenticatedEncryptorBase | |||
| internal abstract class MockableEncryptor : CngAuthenticatedEncryptorBase | |||
There was a problem hiding this comment.
This is test code right? Still. I'm here for it :)
analogrelay
approved these changes
Jul 13, 2019
|
Funny, I did the same search. All those damn forks 😄 |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #11312