Avoid unnecessary body write scheduling in IIS #34733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
HaoK
reviewed
Jul 26, 2021
HaoK
approved these changes
Jul 26, 2021
halter73
force-pushed
the
halter73/inline-iis-output-reader
branch
from
59fad77
to
a8f6c16
Compare
davidfowl
approved these changes
Jul 26, 2021
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only internal logic reads from this Pipe, so there's no reason to dispatch this to another thread to avoid potential blocking. Running the reader loop inline should reduce thread pool load.
This should both improve perf and make in-proc behave better in thread pool starved scenarios. That said, behavior is always going to be bad in thread pool starved scenarios because there's still a bunch of other stuff that gets scheduled. 😄