Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New TryParseModelBinder #40233

Merged
merged 34 commits into from
Mar 3, 2022
Merged

New TryParseModelBinder #40233

merged 34 commits into from
Mar 3, 2022

Conversation

brunolins16
Copy link
Member

@brunolins16 brunolins16 commented Feb 15, 2022 •
edited
Loading

Fixes #39682

@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 15, 2022
@brunolins16 brunolins16 marked this pull request as ready for review February 17, 2022 22:27
@brunolins16 brunolins16 marked this pull request as draft February 17, 2022 22:32
@brunolins16 brunolins16 marked this pull request as ready for review February 18, 2022 16:16
pranavkm
pranavkm approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for driving this PR!

src/Mvc/Mvc.Abstractions/src/ModelBinding/ModelMetadata.cs
}
catch (InvalidOperationException)
{
// The ParameterBindingMethodCache.FindTryParseMethod throws an exception
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion - we could update FindTryParseMethod to not throw via an additional parameter. Not catching exceptions is certainly a lot nicer since it avoids things like first-chance exceptions in VS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I will open a new PR just for that, ok?

src/Mvc/Mvc.Core/src/ModelBinding/Binders/TryParseModelBinder.cs Outdated Show resolved Hide resolved
src/Mvc/Mvc.Core/src/ModelBinding/Binders/TryParseModelBinder.cs Outdated Show resolved Hide resolved
src/Mvc/Mvc.Core/src/ModelBinding/Binders/TryParseModelBinder.cs
Expression.Block(
Expression.Assign(modelValue, Expression.Convert(parsedValue, modelValue.Type)),
Expression.Assign(BindingResultExpression, Expression.Call(SuccessBindingResultMethod, modelValue))),
Expression.Call(AddModelErrorMethod, BindingContextExpression, Expression.Constant(new FormatException()))),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the format exception use https://github.com/dotnet/aspnetcore/blob/main/src/Mvc/Mvc.Abstractions/src/ModelBinding/Metadata/ModelBindingMessageProvider.cs#L41-L47 as the message?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is exactly what the TryAddModelError will do:

aspnetcore/src/Mvc/Mvc.Abstractions/src/ModelBinding/ModelStateDictionary.cs

Line 290 in c962827

if (exception is FormatException || exception is OverflowException)

src/Mvc/Mvc.Core/src/ModelBinding/Metadata/DefaultBindingMetadataProvider.cs Outdated Show resolved Hide resolved
@brunolins16 brunolins16 enabled auto-merge (squash) March 3, 2022 18:24
@brunolins16 brunolins16 merged commit 3817558 into dotnet:main Mar 3, 2022
@ghost ghost added this to the 7.0-preview3 milestone Mar 3, 2022
@brunolins16 brunolins16 mentioned this pull request Mar 16, 2022
Merged
@brunolins16 brunolins16 deleted the brunolins16/issues/39682 branch August 2, 2022 20:49
@halter73 halter73 mentioned this pull request Dec 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@pranavkm pranavkm pranavkm approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@Pilchie Pilchie Awaiting requested review from Pilchie

@Tratcher Tratcher Awaiting requested review from Tratcher

@javiercn javiercn Awaiting requested review from javiercn

@davidfowl davidfowl Awaiting requested review from davidfowl

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
7.0-preview3
Development

Successfully merging this pull request may close these issues.

Consider adding support for TryParse as a way to bind primitives
5 participants
@brunolins16 @davidfowl @pranavkm @BrennanConroy @Pilchie