Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/3: Avoid ConnectionAbortedException allocations #42708

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 13, 2022

Each request is allocating two ConnectionAbortedException instances.

image

After:

image

No more ConnectionAbortedException allocations.

@JamesNK JamesNK merged commit 2ec2536 into main Jul 14, 2022
@JamesNK JamesNK deleted the jamesnk/http3-connectionabortedexception branch July 14, 2022 02:46
@ghost ghost added this to the 7.0-rc1 milestone Jul 14, 2022
@davidfowl davidfowl added the Perf label Aug 26, 2022
@adityamandaleeka adityamandaleeka added the blog-candidate Consider mentioning this in the release blog post label Sep 6, 2022
@ghost
Copy link

ghost commented Sep 6, 2022

@JamesNK, this change will be considered for inclusion in the blog post for the release it'll ship in. Nice work!

Please ensure that the original comment in this thread contains a clear explanation of what the change does, why it's important (what problem does it solve?), and, if relevant, include things like code samples and/or performance numbers.

This content may not be exactly what goes into the blog post, but it will help the team putting together the announcement.

Thanks!

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions blog-candidate Consider mentioning this in the release blog post Perf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants