AddConnections: AddRouting -> AddRoutingCore #56703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-signalr
eerhardt
approved these changes
Jul 9, 2024
Open
3 tasks
JamesNK
approved these changes
Jul 10, 2024
Not to SignalR. Technically someone could create a slim builder, register just SignalR, then add Minimal API routes that use regexes. But that's very unlikely. IMO not worth worrying about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56559
SignalR doesn't require regex constraints so doesn't need the additional config from
AddRouting. Someone can add it back by callingAddRoutingmanually.