Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate appropriate assemblyinfo.cs during compilation #4503

Closed
muratg opened this issue Dec 3, 2015 · 5 comments
Closed

Generate appropriate assemblyinfo.cs during compilation #4503

muratg opened this issue Dec 3, 2015 · 5 comments
Assignees
@pakrym
Milestone
1.0.0-rc2

Comments

@muratg
Copy link

muratg commented Dec 3, 2015

  • Merge with existing user's assembly info?
  • Apply targetframework attribute based on project.json?

@jaredpar Could someone from your team pick this up?

cc @davidfowl @anurse
@jaredpar
Copy link
Member

jaredpar commented Dec 3, 2015

Assigning to @agocke

Do we have a motivating scenario here to drive this issue?

@analogrelay
Copy link
Contributor

project.json has a version field that should be propagated to the Assembly. In DNX we did this by adding a syntax tree defining the necessary attributes. In dotnet-compile we'd probably achieve this by generating a temporary file. The trick is that we do want to allow users to override this with their own AssemblyInfo.cs file. Again, in DNX we did this by scanning the existing syntax trees.

Also, we need to propagate the target framework into the TargetFrameworkAttribute attribute. This is particularly important for desktop targets so that the CLR uses the right quirking mode (i.e. if you build for .NET 4.5 but run on 4.6).

@davidfowl davidfowl assigned pakrym and unassigned agocke Dec 14, 2015
@pakrym
Copy link
Contributor

pakrym commented Dec 15, 2015

dotnet/cli@ab5b16c

@pakrym pakrym closed this as completed Dec 15, 2015
@davidfowl
Copy link
Member

@pakrym You're missing the TargetFrameworkAttribute

@davidfowl davidfowl reopened this Dec 15, 2015
@pakrym
Copy link
Contributor

pakrym commented Dec 16, 2015

https://github.com/dotnet/cli/pull/509/files

@pakrym pakrym closed this as completed Dec 16, 2015
wli3 referenced this issue in wli3/cli Jul 14, 2017
@nguerrera
Merge pull request #398 from nguerrera/resx
aca5d15 
Make all SDK errors localizable
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rc2 milestone Jan 31, 2020
rainersigwald pushed a commit that referenced this issue Jul 20, 2020
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20200…
169f4eb 
…410.3 (#4503)

- Microsoft.Net.Compilers.Toolset: 3.6.0-3.20209.6 -> 3.7.0-1.20210.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pakrym pakrym

Labels
None yet
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
7 participants
@analogrelay @davidfowl @jaredpar @agocke @pakrym @muratg @msftgits