This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Lowercase ID and version in NuGet global packages directory #2722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
force-pushed
the
jver/pathprop
branch
10 times, most recently
from
e64b514
to
757fb3f
Compare
|
/cc @piotrpMSFT @pakrym (please CC other people I am missing) Does these changes look reasonable? I would like to iron out objections to these changes before committing my changes to NuGet (as they are breaking). Once I get sign off, I will create new PR pointing to the real NuGet bits. |
joelverhagen
force-pushed
the
jver/pathprop
branch
3 times, most recently
from
ab22b14
to
c3cc65e
Compare
joelverhagen
force-pushed
the
jver/pathprop
branch
3 times, most recently
from
ac724c9
to
f4e5b90
Compare
joelverhagen
changed the title
joelverhagen
changed the title
joelverhagen
force-pushed
the
jver/pathprop
branch
from
f4e5b90
to
769025a
Compare
| @@ -73,7 +76,10 @@ public void ResolvesAllAssemblies() | |||
| [Fact] | |||
| public void FailsWhenOneOfAssembliesNotFound() | |||
| { | |||
| var packagePath = Path.Combine(PackagesPath, F.DefaultPackageName, F.DefaultVersion); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Updating CoreFx, CoreSetup to rc3-24204-00, rc3-004400 respectively
|
Until I come up with a solid plan to synchronize a core-setup PR (dotnet/core-setup#64) and this PR, this change is on hold. |
Expand timeout setting for project model server
Updating CoreFx, CoreSetup to rc3-24206-00, rc3-004404 respectively
joelverhagen
force-pushed
the
jver/pathprop
branch
from
d07bde2
to
04a7695
Compare
Pass env into ExecCore
Change 'got' to 'received' for dep conflicts
Updating CoreSetup to rc3-004406
…erviceable>true</serviceable> into the output nuspec
… a pack test for the --serviceable option.
… pass a bool instead of a string to enable serviceable.
Porting "dotnet pack -serviceable" change from rel/1.0.0 to 1.0.0-preview2
Bump NuGet version to 3.5.0-rc-1298
joelverhagen
force-pushed
the
jver/pathprop
branch
from
04a7695
to
7389a3a
Compare
eerhardt
added a commit
to eerhardt/cli
that referenced
this pull request
Jul 26, 2016
The new NuGet uses tolower paths, and we need to react to it. Port dotnet#2722 Port dotnet#3554
eerhardt
added a commit
to eerhardt/cli
that referenced
this pull request
Jul 27, 2016
The new NuGet uses tolower paths, and we need to react to it. Port dotnet#2722 Port dotnet#3554
livarcocc
pushed a commit
to livarcocc/core-setup
that referenced
this pull request
Aug 3, 2016
The new NuGet uses tolower paths, and we need to react to it. Port dotnet/cli#2722 Port dotnet/cli#3554
livarcocc
pushed a commit
to livarcocc/core-setup
that referenced
this pull request
Aug 3, 2016
The new NuGet uses tolower paths, and we need to react to it. Port dotnet/cli#2722 Port dotnet/cli#3554
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the latest version of NuGet, which writes packages to the global packages directory with a lowercase ID and version.
Bump NuGet version to 3.5.0-rc-1298.
This change is