-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Clean up from the move to RC3 packages. #3223
Conversation
@@ -5,7 +5,7 @@ | |||
"emitEntryPoint": true | |||
}, | |||
"dependencies": { | |||
"Microsoft.NETCore.App": "1.0.0-rc3-*", | |||
"Microsoft.NETCore.App": "1.0.0-rc2-*", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Can you remove this function: |
@brthor No, I can't use our regular GetRid functions because the coreclr packages don't differentiate windows versions like we do. I mean, if I use our getrid, we may get win10-x64 for instance, and we don't have a win10-x64 coreclr package. Which is why I have kept that function in place. |
Windows is failing due to https://github.com/dotnet/coreclr/issues/5201. |
@livarcocc - You should be unblocked by #3260. |
@livarcocc this is blocking ASP.NET from picking up crossgenned sharedFX. When do you think this will get addressed? CC @piotrpMSFT |
I'm rebasing it now, and will re-submit. |
…dency on NuGet.Config now that we have RC3 packages in the cli-deps feed. Re-enabled crossgen for windows now that we added JITPath to the crossgen call.
Thanks @eerhardt - Please go ahead. |
2858e79
to
5d0aefe
Compare
Removed the dotnet-core dependency on NuGet.Config now that we have RC3 packages in the cli-deps feed.
Re-enabled crossgen for windows now that we added JITPath to the crossgen call.
cc @eerhardt @brthor