Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Clean up from the move to RC3 packages. #3223

Merged
merged 1 commit into from
May 27, 2016

Conversation

livarcocc
Copy link

Removed the dotnet-core dependency on NuGet.Config now that we have RC3 packages in the cli-deps feed.
Re-enabled crossgen for windows now that we added JITPath to the crossgen call.

cc @eerhardt @brthor

@@ -5,7 +5,7 @@
"emitEntryPoint": true
},
"dependencies": {
"Microsoft.NETCore.App": "1.0.0-rc3-*",
"Microsoft.NETCore.App": "1.0.0-rc2-*",

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@brthor
Copy link

brthor commented May 24, 2016

Can you remove this function: private string GetCoreCLRRid() in Crossgen as part of this cleanup?

@livarcocc
Copy link
Author

@brthor No, I can't use our regular GetRid functions because the coreclr packages don't differentiate windows versions like we do. I mean, if I use our getrid, we may get win10-x64 for instance, and we don't have a win10-x64 coreclr package. Which is why I have kept that function in place.

@livarcocc
Copy link
Author

Windows is failing due to https://github.com/dotnet/coreclr/issues/5201.

@eerhardt
Copy link
Member

@livarcocc - You should be unblocked by #3260.

@gkhanna79
Copy link
Member

@livarcocc this is blocking ASP.NET from picking up crossgenned sharedFX. When do you think this will get addressed?

CC @piotrpMSFT

@eerhardt
Copy link
Member

When do you think this will get addressed?

I'm rebasing it now, and will re-submit.

…dency on NuGet.Config now that we have RC3 packages in the cli-deps feed. Re-enabled crossgen for windows now that we added JITPath to the crossgen call.
@gkhanna79
Copy link
Member

Thanks @eerhardt - Please go ahead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants