Populate .deps.json path property with path property from lock file #4053
Conversation
joelverhagen
force-pushed
the
jver/depspath
branch
from
217cf16
to
add3a38
Compare
joelverhagen
changed the title
| @@ -144,6 +144,9 @@ private void ReadLibrary(JObject json, LockFile lockFile) | |||
|
|
|||
| var type = _symbols.GetString(value.Value<string>("type")); | |||
|
|
|||
| var pathValue = value["path"]; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
|
@livarcocc I'm seeing this failure across a few PRs. I believe you were working with some folks on updating System.Reflection.Metadata yesterday. Was Stage0 affected inadvertently? |
|
Yes, not sure what is going on with the CI. For what it's worth, my Windows build fully passed locally. I will wait for a green CI and another sign-off from @livarcocc or @piotrpMSFT. |
joelverhagen
force-pushed
the
jver/depspath
branch
from
9c456ac
to
0f24064
Compare
| <PropertyGroup> | ||
| <SchemaVersion>2.0</SchemaVersion> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" /> | ||
| </ItemGroup> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
|
|
|
I_know_you_are_not_a_fan_When_things_are_consistent @livarcocc ;) |
Update DependencyModel and PlatformAbstractions packages to 1.0.1-beta-000917 Update dotnet-test-xunit to 1.0.0-rc2-330423-54
joelverhagen
force-pushed
the
jver/depspath
branch
from
0f24064
to
aacc30d
Compare
This is step #3 in this NuGet issue: NuGet/Home#2522. This work is also tracked by this CLI issue: https://github.com/dotnet/cli/issues/2874.
This PR adds a
"path"property to the"libraries"entries in the.deps.jsonfile. For packages, this is the relative path appended to the global packages folder (or fallback folder) to access the package's assets. For projects and other library types, this value is null.After this work, the .NET Core host process needs to be modified to prefer this property over the concatenation of the package ID and version.