Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Add symbol packages #499

Merged
merged 1 commit into from
Dec 16, 2015
Merged

Add symbol packages #499

merged 1 commit into from
Dec 16, 2015

Conversation

pakrym
Copy link

@pakrym pakrym commented Dec 15, 2015

@dnfclas
Copy link

dnfclas commented Dec 15, 2015

Hi @pakrym, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@analogrelay
Copy link

Conflicts! :(.

Looks good though, :shipit: if the conflicts don't change it dramatically.

@davidfowl
Copy link
Member

This doesn't look complete. Where are the source files being added? Make sure this works end to end

@davidfowl
Copy link
Member

Also make sure it does the same thing as dnu pack

@pakrym
Copy link
Author

pakrym commented Dec 15, 2015

That's embarrassing, somehow I was sure symbols package was only for symbols. Would fix and double test.

@pakrym
Copy link
Author

pakrym commented Dec 15, 2015

🆙 📅

@davidfowl
Copy link
Member

Looks good. :shipit:

@pakrym pakrym merged commit ce2628d into master Dec 16, 2015
@pakrym pakrym deleted the pakrym/sympack branch December 22, 2015 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants