Use net8.0 TFM when building with source-build #2150
Conversation
| @@ -11,11 +11,11 @@ | |||
| <LangVersion>10.0</LangVersion> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="'$(DisableArcade)' == '1'"> | |||
There was a problem hiding this comment.
Why is this being removed?
There was a problem hiding this comment.
Because it had no impact. The property being set was identical between the two conditions. If you want it back, can you suggest how it should be defined given these current changes?
There was a problem hiding this comment.
These changes LGTM. I do have a related question though. I am concerned that repo level prebuilt detection is not working as expected here. Why wasn't the net7.0 shared framework being flagged as a prebuilt prior to this change? Can you follow up on this or log an issue to track this down?
Probably because it's using 7.0 SDK: https://github.com/dotnet/command-line-api/blob/main/global.json#L3 |
Of course, that makes sense. |
|
@jonsequitur - I've reverted the changes to the sample projects so that they use a hard-coded |
|
@jonsequitur - Can you review my latest update? Go ahead and merge if it looks good. |
|
Thanks, @mthalman! |
When attempting to enable PVP flow for the command-line-api, a prebuilt was detected for Microsoft.NET.ILLink.Tasks.7.0.100-1.23062.2. This occurs as a result of the enablement of trimming for the System.CommandLine project.
This is resolved by configuring the repo to target the
net8.0TFM instead ofnet7.0when building with source-build.Let's use this PR to iterate on any requested changes. Once we finalize the changes, I'll create a patch for source-build to use in addition to merging this PR.
cc @mmitche @MichaelSimons @jonsequitur