Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Remove PAL_printf_arg_remover #271

Merged
merged 1 commit into from
Feb 19, 2015
Merged

Conversation

kangaroo
Copy link

The current code seems to assume that va_lists need manual advancing.
This is against the standard, and actually breaks many things rather badly on OSX.
Remove it, and favor va_copy as needed. Fixes all PAL tests in debug and release mode on OS X

@dnfclas
Copy link

dnfclas commented Feb 14, 2015

Hi @kangaroo, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@sergiy-k
Copy link

LGTM.

@dnfclas
Copy link

dnfclas commented Feb 16, 2015

@kangaroo, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@sergiy-k
Copy link

@janvorli Could you please take a look as well and give second approval so we can merge this change? Thank you.

@kangaroo
Copy link
Author

Is this blocked on something? Can someone give second review please?

@jkotas
Copy link
Member

jkotas commented Feb 19, 2015

LGTM

jkotas added a commit that referenced this pull request Feb 19, 2015
@jkotas jkotas merged commit ee90a8b into dotnet:master Feb 19, 2015
@benpye benpye mentioned this pull request Jul 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants