Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Inital build support for FreeBSD. #453

Merged
merged 1 commit into from Mar 16, 2015
Merged

Inital build support for FreeBSD. #453

merged 1 commit into from Mar 16, 2015

Conversation

janhenke
Copy link
Member

Add FreeBSD to various build scripts, so this platform is detected and properly configured. FreeBSD is another Unix-like OS also supported within Microsoft Azure.

This patch just makes FreeBSD known to the build scripts.

@janhenke
Copy link
Member Author

Fixed the formatting in build.sh as requested. Please review.

desired_llvm_version=35
else
desired_llvm_version=3.5
fi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to break this into __LLVM_major and _LLMV_minor, and then do platform specific concatenation. The current mess is getting a bit soupy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janhenke could you please fix this one as well? (And also make the indentation to match the surrounding code.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had that originally too, but felt it made that code to messy to break it up. But if you think it is better I will change it and try to make it look cleanly as possible.

Add FreeBSD to various build scripts, so this platform is detected and properly
configured.
@janhenke
Copy link
Member Author

Reworked the formatting and made the llvm string building work more generalized. Please review.

@jkotas
Copy link
Member

jkotas commented Mar 16, 2015

Thanks!

jkotas added a commit that referenced this pull request Mar 16, 2015
Inital build support for FreeBSD.
@jkotas jkotas merged commit e17f380 into dotnet:master Mar 16, 2015
@richlander richlander added the os-freebsd FreeBSD OS label Apr 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
os-freebsd FreeBSD OS
Projects
None yet
5 participants