Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inital build support for FreeBSD. #453

Merged
merged 1 commit into from Mar 16, 2015
Merged

Inital build support for FreeBSD. #453

merged 1 commit into from Mar 16, 2015

Conversation

@janhenke
Copy link
Member

@janhenke janhenke commented Mar 15, 2015

Add FreeBSD to various build scripts, so this platform is detected and properly configured. FreeBSD is another Unix-like OS also supported within Microsoft Azure.

This patch just makes FreeBSD known to the build scripts.

@janhenke janhenke force-pushed the janhenke:freebsd branch from c23d51e to ad9c313 Mar 15, 2015
@janhenke
Copy link
Member Author

@janhenke janhenke commented Mar 15, 2015

Fixed the formatting in build.sh as requested. Please review.

desired_llvm_version=35
else
desired_llvm_version=3.5
fi

This comment has been minimized.

@kangaroo

kangaroo Mar 16, 2015

It might be better to break this into __LLVM_major and _LLMV_minor, and then do platform specific concatenation. The current mess is getting a bit soupy.

This comment has been minimized.

@jkotas

jkotas Mar 16, 2015
Member

@janhenke could you please fix this one as well? (And also make the indentation to match the surrounding code.)

This comment has been minimized.

@janhenke

janhenke Mar 16, 2015
Author Member

I had that originally too, but felt it made that code to messy to break it up. But if you think it is better I will change it and try to make it look cleanly as possible.

Add FreeBSD to various build scripts, so this platform is detected and properly
configured.
@janhenke janhenke force-pushed the janhenke:freebsd branch from ad9c313 to f0553c3 Mar 16, 2015
@janhenke
Copy link
Member Author

@janhenke janhenke commented Mar 16, 2015

Reworked the formatting and made the llvm string building work more generalized. Please review.

@jkotas
Copy link
Member

@jkotas jkotas commented Mar 16, 2015

Thanks!

jkotas added a commit that referenced this pull request Mar 16, 2015
Inital build support for FreeBSD.
@jkotas jkotas merged commit e17f380 into dotnet:master Mar 16, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dotnet-bot
default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants