This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Inital build support for FreeBSD. #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed the formatting in build.sh as requested. Please review. |
| desired_llvm_version=35 | ||
| else | ||
| desired_llvm_version=3.5 | ||
| fi |
There was a problem hiding this comment.
It might be better to break this into __LLVM_major and _LLMV_minor, and then do platform specific concatenation. The current mess is getting a bit soupy.
There was a problem hiding this comment.
@janhenke could you please fix this one as well? (And also make the indentation to match the surrounding code.)
There was a problem hiding this comment.
I had that originally too, but felt it made that code to messy to break it up. But if you think it is better I will change it and try to make it look cleanly as possible.
Add FreeBSD to various build scripts, so this platform is detected and properly configured.
|
Reworked the formatting and made the llvm string building work more generalized. Please review. |
|
Thanks! |
jkotas
added a commit
that referenced
this pull request
Mar 16, 2015
Inital build support for FreeBSD.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FreeBSD to various build scripts, so this platform is detected and properly configured. FreeBSD is another Unix-like OS also supported within Microsoft Azure.
This patch just makes FreeBSD known to the build scripts.