Commits on Feb 22, 2017

1. Fix SqlClient diagnostic test failures …

   Two issues:
   - Tests from the DiagnosticTests class might run concurrently with tests from other test classes.  This could cause interference between the tests.
   - The CollectStatisticsDiagnosticsAsync method was void returning, which meant the test harness would not wait for its completion before processing other tests.  This could both cause interference between the tests (including other diagnostics tests) and cause unhandled exceptions to tear down the test process.
   
   Fixes:
   - Use RemoteInvoke to launch each diagnostic test in its own process so that it doesn't experience or cause interference with other tests.
   - Ensure that all operations are appropriately waited for.

   

   stephentoub committed Feb 22, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for ad23153
   • Browse repository at this point

   Copy the full SHA

   ad23153 View commit details

   Browse the repository at this point in the history

2. Add missing ConditionalFact for IsConnectionStringConfigured

   

   stephentoub committed Feb 22, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 160dad0
   • Browse repository at this point

   Copy the full SHA

   160dad0 View commit details

   Browse the repository at this point in the history

3. Tweak RemoteExecutorTestBase slightly …

   Increase fail-wait timeout in case a machine is bogged down, and add a better assert message

   

   stephentoub committed Feb 22, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for bb02c8f
   • Browse repository at this point

   Copy the full SHA

   bb02c8f View commit details

   Browse the repository at this point in the history