This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Replace files with CoreLib mirror (<30% differences) #29433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sounds good to me. If |
|
|
MarcoRossignoli
changed the title
MarcoRossignoli
changed the title
MarcoRossignoli
commented
May 2, 2018
| <Compile Include="$(CommonPath)\Interop\Windows\Interop.Libraries.cs"> | ||
| <Link>Common\Interop\Windows\Interop.Libraries.cs</Link> | ||
| </Compile> | ||
| <Compile Include="$(CommonPath)\Interop\Windows\kernel32\Interop.GetCPInfoEx.cs"> | ||
| <Link>Common\Interop\Windows\Interop.GetCPInfoEx.cs</Link> | ||
| </Compile> | ||
| <Compile Include="$(CommonPath)\CoreLib\Interop\Windows\Kernel32\Interop.WideCharToMultiByte.cs"> |
There was a problem hiding this comment.
@jkotas constants are used only here...i removed file on corefx and added reference to corelib. Is this a good compromise to you?(If not i can create a Interop.Encoding.Constants.cs on corecrl, remove from existent cs and after merge on corefx change ref here)
stephentoub
approved these changes
May 2, 2018
jkotas
approved these changes
May 2, 2018
|
@MarcoRossignoli Thank you! |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…9433) * remove duplicates * remove unused Interop.GetFullPathNameW.cs * revert TupleExtensions.cs for netfx incompatibility * replace coreclr merged * replace constants conflicts Commit migrated from dotnet/corefx@5168f54
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #27841
there are other files:
corefx\src\Common\src\CoreLib\Interop\Windows\Kernel32\Interop.MultiByteToWideChar.cs
corefx\src\Common\src\Interop\Windows\kernel32\Interop.MultiByteToWideChar.cs
corefx\src\Common\src\CoreLib\Interop\Windows\Kernel32\Interop.SetThreadErrorMode.cs
corefx\src\Common\src\Interop\Windows\kernel32\Interop.SetThreadErrorMode.cs
corefx\src\Common\src\CoreLib\Interop\Windows\Kernel32\Interop.WideCharToMultiByte.cs
corefx\src\Common\src\Interop\Windows\kernel32\Interop.WideCharToMultiByte.cs
but to replace those we need to move "constants" of CoreLib files somewhere because collide with constants on corefx(es. corefx\src\Common\src\Interop\Windows\kernel32\Interop.Encoding.Constants.cs).
Any idea?
cc: @danmosemsft @jkotas