This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix proxy connect tunnel test #30007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was hanging on most handlers except for SocketsHttpHandler. It was hanging because the await'ed task of connecting to the proxy never happened. Except for SocketsHttpHandler, the other handlers optimize loopback so that if the destination server is on loopback, then it ignores any proxy setting. The test was using both a loopback destination server as well as a loopback proxy server. This test is one of the few tests that do an end-to-end request/response thru a proxy. So, it's important that we keep the test and have it work on all handlers. Modified the test to use a real external server destination. The test still uses a loopback proxy server. I also moved some of the Outerloop tests to Innerloop since those tests were using loopback. Fixes #27746
davidsh
added
test bug
stephentoub
reviewed
May 31, 2018
| @@ -2230,7 +2221,7 @@ public void GetAsync_ServerNeedsAuthAndNoCredential_StatusCodeUnauthorized() | |||
| server => server.AcceptConnectionSendResponseAndCloseAsync()); | |||
| } | |||
|
|
|||
| [OuterLoop] // TODO: Issue #11345 | |||
| [OuterLoop("Multiple connections")] | |||
There was a problem hiding this comment.
Does this one need to be outerloop?
There was a problem hiding this comment.
I was concerned at first that it might take a longer time since it used multiple connections. But we can probably get rid of the Outerloop.
stephentoub
reviewed
May 31, 2018
| await serverTask; | ||
| }, options); | ||
| await proxy; | ||
| await TaskTimeoutExtensions.WhenAllOrAnyFailed(new Task[] { proxyTask }, TestHelper.PassingTestTimeoutMilliseconds); |
There was a problem hiding this comment.
This isn't waiting on multiple tasks anymore, so the WhenAllOrAnyFailed isn't needed. It can instead be:
await proxyTask.TimeoutAfter(TestHelper.PassingTestTimeoutMilliseconds);There was a problem hiding this comment.
Thx. I'll change that.
stephentoub
approved these changes
May 31, 2018
|
@dotnet-bot test Outerloop Windows x64 Debug Build |
|
Unrelated CI failures in XsltCompiler tests on RS4: |
caesar-chen
pushed a commit
to caesar-chen/corefx
that referenced
this pull request
Jun 1, 2018
The test was hanging on most handlers except for SocketsHttpHandler. It was hanging because the await'ed task of connecting to the proxy never happened. Except for SocketsHttpHandler, the other handlers optimize loopback so that if the destination server is on loopback, then it ignores any proxy setting. The test was using both a loopback destination server as well as a loopback proxy server. This test is one of the few tests that do an end-to-end request/response thru a proxy. So, it's important that we keep the test and have it work on all handlers. Modified the test to use a real external server destination. The test still uses a loopback proxy server. I also moved some of the Outerloop tests to Innerloop since those tests were using loopback. Fixes #27746
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
The test was hanging on most handlers except for SocketsHttpHandler. It was hanging because the await'ed task of connecting to the proxy never happened. Except for SocketsHttpHandler, the other handlers optimize loopback so that if the destination server is on loopback, then it ignores any proxy setting. The test was using both a loopback destination server as well as a loopback proxy server. This test is one of the few tests that do an end-to-end request/response thru a proxy. So, it's important that we keep the test and have it work on all handlers. Modified the test to use a real external server destination. The test still uses a loopback proxy server. I also moved some of the Outerloop tests to Innerloop since those tests were using loopback. Fixes dotnet/corefx#27746 Commit migrated from dotnet/corefx@2edbc59
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was hanging on most handlers except for SocketsHttpHandler. It was hanging because
the await'ed task of connecting to the proxy never happened. Except for SocketsHttpHandler,
the other handlers optimize loopback so that if the destination server is on loopback, then it
ignores any proxy setting. The test was using both a loopback destination server as well as a
loopback proxy server.
This test is one of the few tests that do an end-to-end request/response thru a proxy. So, it's
important that we keep the test and have it work on all handlers. Modified the test to use a real
external server destination. The test still uses a loopback proxy server.
I also moved some of the Outerloop tests to Innerloop since those tests were using loopback.
Fixes #27746