Update CoreClr, CoreFx, CoreFxOptimizationData, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview-27113-06, preview.18563.5, master-20181114-0045, preview-27114-01, beta-27114-00, beta-27114-00, respectively (master)

[dotnet-maestro-bot]

No description provided.

[dotnet-maestro-bot]

Discarded 7155fa4: Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview-27113-06, preview.18563.5, preview-27113-06, beta-27114-00, beta-27114-00, respectively

CI Status: 1:x: 12:heavy_check_mark: (click to expand)

• ❌ Packaging All Configurations x64 Debug Build Build finished. Details
• ✔️ license/cla All CLA requirements met. Details
• ✔️ Linux arm Release Build Build finished. Details
• ✔️ Linux arm64 Release Build Build finished. Details
• ✔️ Linux x64 Release Build Build finished. Details
• ✔️ Linux-musl x64 Debug Build Build finished. Details
• ✔️ NETFX x86 Release Build Build finished. Details
• ✔️ OSX x64 Debug Build Build finished. Details
• ✔️ Tizen armel Debug Build Build finished. Details
• ✔️ UWP CoreCLR x64 Debug Build Build finished. Details
• ✔️ UWP NETNative x86 Release Build Build finished. Details
• ✔️ Windows x64 Debug Build Build finished. Details
• ✔️ Windows x86 Release Build Build finished. Details

[stephentoub]

@dotnet-bot test Packaging All Configurations x64 Debug Build please

[stephentoub]

@tannergooding, the Packaging All Configurations build is hitting a ton of errors, many of which are of the form:

D:\j\workspace\windows-TGrou---0d2c9ac4\artifacts\bin\testPkg\packageTest.targets(85,5): error : Duplicate type System.Buffers.StandardFormat in both D:\j\workspace\windows-TGrou---0d2c9ac4\artifacts\bin\testPackages\runtime.osx-x64.microsoft.netcore.app\3.0.0-preview-27114-01\runtimes\osx-x64\native\System.Private.CoreLib.dll and D:\j\workspace\windows-TGrou---0d2c9ac4\artifacts\bin\testPackages\runtime.osx-x64.microsoft.netcore.app\3.0.0-preview-27114-01\runtimes\osx-x64\lib\netcoreapp3.0\System.Memory.dll. [D:\j\workspace\windows-TGrou---0d2c9ac4\artifacts\bin\testPkg\projects\System.Reflection.TypeExtensions\netcoreapp3.0\project.csproj] [D:\j\workspace\windows-TGrou---0d2c9ac4\pkg\test\testPackages.proj]
D:\j\workspace\windows-TGrou---0d2c9ac4\artifacts\bin\testPkg\packageTest.targets(85,5): error : Duplicate type System.Buffers.Text.Utf8Formatter in both D:\j\workspace\windows-TGrou---0d2c9ac4\artifacts\bin\testPackages\runtime.osx-x64.microsoft.netcore.app\3.0.0-preview-27114-01\runtimes\osx-x64\native\System.Private.CoreLib.dll and D:\j\workspace\windows-TGrou---0d2c9ac4\artifacts\bin\testPackages\runtime.osx-x64.microsoft.netcore.app\3.0.0-preview-27114-01\runtimes\osx-x64\lib\netcoreapp3.0\System.Memory.dll. [D:\j\workspace\windows-TGrou---0d2c9ac4\artifacts\bin\testPkg\projects\System.Reflection.TypeExtensions\netcoreapp3.0\project.csproj] [D:\j\workspace\windows-TGrou---0d2c9ac4\pkg\test\testPackages.proj]
D:\j\workspace\windows-TGrou---0d2c9ac4\artifacts\bin\testPkg\packageTest.targets(85,5): error : Duplicate type System.Buffers.Text.Utf8Parser in both D:\j\workspace\windows-TGrou---0d2c9ac4\artifacts\bin\testPackages\runtime.osx-x64.microsoft.netcore.app\3.0.0-preview-27114-01\runtimes\osx-x64\native\System.Private.CoreLib.dll and D:\j\workspace\windows-TGrou---0d2c9ac4\artifacts\bin\testPackages\runtime.osx-x64.microsoft.netcore.app\3.0.0-preview-27114-01\runtimes\osx-x64\lib\netcoreapp3.0\System.Memory.dll. [D:\j\workspace\windows-TGrou---0d2c9ac4\artifacts\bin\testPkg\projects\System.Reflection.TypeExtensions\netcoreapp3.0\project.csproj] [D:\j\workspace\windows-TGrou---0d2c9ac4\pkg\test\testPackages.proj]

Could you take a look? I assume this is related to your recent move of these types.

[tannergooding]

Looking...

[tannergooding]

Hmm, the testPackages\runtime.osx-x64.microsoft.netcore.app\3.0.0-preview-27114-01\runtimes\osx-x64\lib\netcoreapp3.0\System.Memory.dll file looks like it is actually the v2.1.5 implementation assembly.

@ericstj, @joperezr is that expected? Am I missing a forward or redirect (the implementation was moved into S.P.Corelib)?

[ericstj]

To fix this we can add

  <ItemGroup>
    <IgnoredTypes Include="System.Buffers.StandardFormat" />
    <IgnoredTypes Include="System.Buffers.Text.Utf8Formatter" />
    <IgnoredTypes Include="System.Buffers.Text.Utf8Parser" />
  </ItemGroup>

to https://github.com/dotnet/corefx/blob/master/pkg/test/frameworkSettings/netcoreapp3.0/settings.targets

Then file an issue to remove that on the next build of core-setup that has the types removed from System.Memory.

[tannergooding]

Talked with @ericstj and @joperezr, this is because core-setup doesn't yet have the changes where the implementation was removed from System.Memory.

We can use the workaround @ericstj provided above to workaround the issue.

[tannergooding]

Should be resolved. I have logged https://github.com/dotnet/corefx/issues/33487 to track removing the workaround.

Thanks for the help!

[stephentoub]

Thanks, all.