This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
SqlClient minor cleanup to close old issues #34711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabh500
reviewed
Jan 23, 2019
src/System.Data.SqlClient/src/System/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
|
@dotnet-bot test OSX x64 Debug Build |
saurabh500
approved these changes
Jan 29, 2019
|
@Wraith2 can you also get the latest changes for this pr as well? |
|
Done, and triggered. I'll work through the other open PR's over the weekend because some will need merge conflict resolution. |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Merging since the CI failures are not related to the changes made with this PR. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
SqlClient minor cleanup to close old issues Commit migrated from dotnet/corefx@ee6cf5a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/6134
Fixes https://github.com/dotnet/corefx/issues/5450
Tiny code changes, one to ensure that statistics are handled using try-finally blocks and another to make sure that an AutoResetEvent is cleaned up when the parser instance is disconnected. Auto and manual tests pass.
/cc the usual suspects @afsanehr @keeratsingh @saurabh500