Add codecov yml configuration #34896
Conversation
| range: 60...90 | ||
|
|
||
| comment: | ||
| layout: "reach, diff, files" |
There was a problem hiding this comment.
💡 reach is an impediment to mobile browsing and does not really provide a benefit. I recommend omitting files as well, though this can wait until some point in the future when you realize it's not especially helpful 😄
| codecov: | ||
| branch: master | ||
| ci: | ||
| - dnceng.visualstudio.com |
There was a problem hiding this comment.
❔ Can you provide more information about what this does?
There was a problem hiding this comment.
Sure: https://docs.codecov.io/docs/detecting-ci-services#section-detection-technique.
As we upload our reports from helix machines, the codecov's detection technique fails and can't figure out which CI service is used. We ideally should set this variable in the teams codecov yml but I don't permissions to do so: https://docs.codecov.io/docs/codecov-yaml#section-team-yaml
| - dnceng.visualstudio.com | ||
|
|
||
| coverage: | ||
| range: 60...90 |
There was a problem hiding this comment.
❔ Can you describe the motivation behind this range? I always recommend that teams using code coverage tools never gate on a particular coverage number, but I can think of other reasons why this might be included. I'm curious why it's used here.
There was a problem hiding this comment.
I lowered the lower bound temporarily as our coverage numbers aren't great for most of our libraries. As soon as codecov integration is enabled in corefx I will adjust these settings based on what makes sense.
Commit migrated from dotnet/corefx@88d519b
Adding a codecov.yml file to adjust some settings, most importantly the CI provider setting which is necessary as we will use helix to upload the reports.
https://docs.codecov.io/docs/codecov-yaml