Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Make global tools work with helix #34913

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Conversation

ViktorHofer
Copy link
Member

Depends on dotnet/arcade#1897

eng/sendtohelix.proj Outdated Show resolved Hide resolved
@@ -80,11 +80,24 @@
<_RuntimeInputs Include="$(TestHostRootPath)**/*.dll" />
</ItemGroup>

<!-- Add global tools to runtime -->
<ItemGroup Condition="'$(TargetsNetCoreApp)' == 'true'">
<TestArchiveRuntimeDependencies Include="$(GlobalToolsDir)**\*.*" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: prefix with _?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be used from outside to add additional runtime dependencies therefore no underscore.

@ViktorHofer ViktorHofer merged commit 409c4b9 into dotnet:master Jan 29, 2019
@karelz karelz added this to the 3.0 milestone Mar 18, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Make global tools work with helix

* Add runtime dependencies as target inputs


Commit migrated from dotnet/corefx@409c4b9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants