Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[WIP] Add code coverage build definition. #35296

Closed
wants to merge 1 commit into from

Conversation

safern
Copy link
Member

@safern safern commented Feb 13, 2019

This brings us closer to having code coverage with the new build system.

cc: @danmosemsft @ericstj

@safern
Copy link
Member Author

safern commented Feb 13, 2019

Here is the code coverage build: https://dev.azure.com/dnceng/internal/_build/results?buildId=94565

@safern safern force-pushed the CodeCoverageDefinition branch 2 times, most recently from 07d446b to 194b875 Compare February 13, 2019 19:23
@safern
Copy link
Member Author

safern commented Feb 13, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@ViktorHofer ViktorHofer added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 13, 2019
@ViktorHofer ViktorHofer force-pushed the CodeCoverageDefinition branch 2 times, most recently from 23ea5d5 to 6a12518 Compare February 13, 2019 21:53
@safern safern force-pushed the CodeCoverageDefinition branch 6 times, most recently from 2e264d0 to 591a190 Compare February 14, 2019 07:32
@ViktorHofer ViktorHofer force-pushed the CodeCoverageDefinition branch 2 times, most recently from 449c367 to 5644884 Compare February 14, 2019 12:13
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c776f65). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35296   +/-   ##
=========================================
  Coverage          ?   93.03%           
=========================================
  Files             ?       35           
  Lines             ?     9833           
  Branches          ?        0           
=========================================
  Hits              ?     9148           
  Misses            ?      685           
  Partials          ?        0
Flag Coverage Δ
#Debug 93.03% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c776f65...3dfc99a. Read the comment docs.

@safern
Copy link
Member Author

safern commented Feb 27, 2019

@ViktorHofer I added: dc42790 to upload coverage.xml to azure and then add the settings to download them to the build machine. This is just dependent on: dotnet/arcade#2103

@safern
Copy link
Member Author

safern commented Feb 28, 2019

/azp run corefx-outerloop-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@safern
Copy link
Member Author

safern commented Feb 28, 2019

/azp run corefx-outerloop-windows

@dotnet dotnet deleted a comment from azure-pipelines bot Feb 28, 2019
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karelz
Copy link
Member

karelz commented Mar 18, 2019

@safern this seems to be blocked stale PR. Can we close it now, or does it serve some active purpose? Thanks!

@safern
Copy link
Member Author

safern commented Mar 18, 2019

@safern this seems to be blocked stale PR. Can we close it now, or does it serve some active purpose? Thanks!

We're blocked on: https://github.com/dotnet/core-eng/issues/5482 to make progress since we can't make any progress since we're hitting that issue.

@ViktorHofer ViktorHofer force-pushed the CodeCoverageDefinition branch 3 times, most recently from 1da6d5d to c53c665 Compare March 25, 2019 14:49
@ViktorHofer
Copy link
Member

@safern I had to manually merge the changes with master and force pushed.

@ViktorHofer
Copy link
Member

Things left for this PR:

  • Add ReportGenerator step which bundles all the reports together (in yml)
  • Add CodeCovExe step which upload the generated report (in yml). Requires CodeCovExe to be published as a AzDO task. Will work on that.

@safern
Copy link
Member Author

safern commented Mar 25, 2019

Add ReportGenerator step which bundles all the reports together (in yml)
Add CodeCovExe step which upload the generated report (in yml). Requires CodeCovExe to be published as a AzDO task. Will work on that.

Maybe both steps could be part of the AzDO task? To make it easier for other folks as well.

@ViktorHofer
Copy link
Member

ReportGenerator is already a AzDO task. Codecov makes sense to be separated. Usually you won't use both unless you are special

@karelz karelz added this to the 3.0 milestone Apr 1, 2019
@karelz
Copy link
Member

karelz commented Apr 13, 2019

@safern @ViktorHofer is there any update on this? If it is not ready (e.g. due to dependencies in CoreCLR), let's close it, until we can make further progress on it ... thanks!

@safern safern closed this Apr 13, 2019
@safern
Copy link
Member Author

safern commented Apr 13, 2019

Yeah. We also need to merge with the latest changes in the YAML. We’re mostly blocked on helix issue with long paths.

@ViktorHofer ViktorHofer reopened this Apr 25, 2019
@ViktorHofer
Copy link
Member

Reopening as I'm now going to continue this work and want to have CI support.

@ViktorHofer ViktorHofer force-pushed the CodeCoverageDefinition branch 4 times, most recently from b3e8575 to 0684d91 Compare April 25, 2019 15:02
@karelz
Copy link
Member

karelz commented May 22, 2019

@ViktorHofer again looks like stalled for 4 weeks :( ... should we close it again?

@ViktorHofer
Copy link
Member

Closing again until I have more time for code coverage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants