-
Notifications
You must be signed in to change notification settings - Fork 4.9k
[WIP] Add code coverage build definition. #35296
Conversation
468e307
to
cf9ae77
Compare
Here is the code coverage build: https://dev.azure.com/dnceng/internal/_build/results?buildId=94565 |
07d446b
to
194b875
Compare
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
23ea5d5
to
6a12518
Compare
2e264d0
to
591a190
Compare
449c367
to
5644884
Compare
566ac75
to
47a1f9c
Compare
Codecov Report
@@ Coverage Diff @@
## master #35296 +/- ##
=========================================
Coverage ? 93.03%
=========================================
Files ? 35
Lines ? 9833
Branches ? 0
=========================================
Hits ? 9148
Misses ? 685
Partials ? 0
Continue to review full report at Codecov.
|
a46bae6
to
5fdfa2e
Compare
@ViktorHofer I added: dc42790 to upload coverage.xml to azure and then add the settings to download them to the build machine. This is just dependent on: dotnet/arcade#2103 |
dc42790
to
d3748ac
Compare
/azp run corefx-outerloop-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run corefx-outerloop-windows |
Azure Pipelines successfully started running 1 pipeline(s). |
@safern this seems to be blocked stale PR. Can we close it now, or does it serve some active purpose? Thanks! |
We're blocked on: https://github.com/dotnet/core-eng/issues/5482 to make progress since we can't make any progress since we're hitting that issue. |
1da6d5d
to
c53c665
Compare
@safern I had to manually merge the changes with master and force pushed. |
Things left for this PR:
|
Maybe both steps could be part of the AzDO task? To make it easier for other folks as well. |
ReportGenerator is already a AzDO task. Codecov makes sense to be separated. Usually you won't use both unless you are special |
@safern @ViktorHofer is there any update on this? If it is not ready (e.g. due to dependencies in CoreCLR), let's close it, until we can make further progress on it ... thanks! |
Yeah. We also need to merge with the latest changes in the YAML. We’re mostly blocked on helix issue with long paths. |
Reopening as I'm now going to continue this work and want to have CI support. |
b3e8575
to
0684d91
Compare
0684d91
to
b939f58
Compare
@ViktorHofer again looks like stalled for 4 weeks :( ... should we close it again? |
Closing again until I have more time for code coverage. |
This brings us closer to having code coverage with the new build system.
cc: @danmosemsft @ericstj