Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[3.1] Some overlooked credscan fixes #43057

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

danmoseley
Copy link
Member

@aik-jahoda this is needed in 2.1, 5.0 and main as well.

I'll let CI run this test..

@aik-jahoda
Copy link

Interesting. I didn't seen this as a problem during local run and I can't reproduce the bugs now. Not sure if we need this change.

@danmoseley
Copy link
Member Author

I was using 2.2.5. Does that repro it for you?

@aik-jahoda aik-jahoda changed the title Some overlooked credscan fixes [3.1] Some overlooked credscan fixes Mar 25, 2021
@aik-jahoda
Copy link

5.0 - dotnet/runtime#50120
6.0 - dotnet/runtime#50230
2.1 - #43058

@danmoseley
Copy link
Member Author

I'll let you handle merging this

@danmoseley
Copy link
Member Author

    System.Xml.Tests.CNameTableTestModule.RunTests(testCase: Get Valid Super String) [FAIL]
      OLEDB.Test.ModuleCore.CTestException : objTest3 is  null
      Expected: `True`
      Actual: `False`
      Result: 0
      
      Stack Trace:
        /_/src/System.Private.Xml/tests/Readers/NameTable/XmlNameTable.cs(355,0): at System.Xml.Tests.TCRecordNameTableGet.Variation_10()
        /_/src/Common/tests/System/Xml/ModuleCore/cvariation.cs(77,0): at OLEDB.Test.ModuleCore.CVariation.Execute()
        /_/src/Common/tests/System/Xml/ModuleCore/ctestcase.cs(132,0): at OLEDB.Test.ModuleCore.CTestCase.<>c__DisplayClass7_1.<TestCases>b__0()
        /_/src/Common/tests/System/Xml/ModuleCore/XunitTestCase.cs(34,0): at OLEDB.Test.ModuleCore.XunitTestCase.Run()
        /_/src/System.Private.Xml/tests/Readers/NameTable/CNameTableTestModule.cs(17,0): at System.Xml.Tests.CNameTableTestModule.RunTests(XunitTestCase testCase)

unrelated

@danmoseley danmoseley merged commit b238500 into dotnet:release/3.1 Mar 26, 2021
@danmoseley danmoseley deleted the 3.1credscan branch March 26, 2021 02:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants