Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0] Credscan #50120

Merged
merged 13 commits into from
Mar 26, 2021
Merged

[5.0] Credscan #50120

merged 13 commits into from
Mar 26, 2021

Conversation

aik-jahoda
Copy link
Contributor

@aik-jahoda aik-jahoda commented Mar 23, 2021 •
edited
Loading

This is port of dotnet/corefx#43051

for 6.0 - #50230

@ghost
Copy link

ghost commented Mar 23, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This is port of dotnet/corefx#43051

Author: aik-jahoda
Assignees: -
Labels:

area-System.Net
Milestone: -

@aik-jahoda aik-jahoda marked this pull request as draft March 23, 2021 20:12
danmoseley
danmoseley approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check with @Anipik / @wtgodbe that we can merge asap.

@wtgodbe
Copy link
Member

wtgodbe commented Mar 23, 2021

Merging ASAP is ok, but again please make sure to cancel the triggered internal builds of release/5.0 and internal/release/5.0

@aik-jahoda aik-jahoda mentioned this pull request Mar 25, 2021
Merged
@aik-jahoda aik-jahoda mentioned this pull request Mar 25, 2021
Merged
@aik-jahoda aik-jahoda marked this pull request as ready for review March 25, 2021 13:51
@aik-jahoda aik-jahoda requested a review from wfurt March 25, 2021 13:52
@danmoseley
Copy link
Member

System.Security.Cryptography.X509Certificates.Tests failure is the occasional sporadic OS error we get on Windows.

@danmoseley
Copy link
Member

BSD run seems jammed. I'm not going to wait on that as the probability that this introduces a BSD-unique issue is vanishingly small.

@danmoseley danmoseley merged commit aa235f8 into dotnet:release/5.0 Mar 26, 2021
@aik-jahoda aik-jahoda deleted the jajahoda/cred-5.0 branch March 26, 2021 07:38
@runfoapp runfoapp bot mentioned this pull request Mar 26, 2021
Open
@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2021
@karelz karelz modified the milestones: 5.0.0, 5.0.x May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley approved these changes

@wfurt wfurt Awaiting requested review from wfurt

Assignees
No one assigned
Labels
area-System.Net
Projects
None yet
Milestone
5.0.x
Development

Successfully merging this pull request may close these issues.
4 participants
@aik-jahoda @wtgodbe @danmoseley @karelz