Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Write more performance tests and optimize runtime performance #64

Closed
KrzysztofCwalina opened this issue Mar 27, 2015 · 1 comment
Closed
Labels
area-System.Text.Formatting OpenBeforeArchiving These issues were open before the repo was archived. For re-open them, file them in the new repo up-for-grabs
Milestone

Comments

@KrzysztofCwalina
Copy link
Member

  1. Formatting UTF8 strings does not have performance tests
  2. Number formatter is calling ToUpper on the format character. This regressed perf a bit in the past.
  3. Math.DivRem (used in hot formatting loop) generates two idiv instructions. it should be just one.
  4. It would be worth to again profile the perf tests. There were significant changes since last time.
  5. Composite formatting does not have perf or memory tests.
@KrzysztofCwalina KrzysztofCwalina self-assigned this Nov 10, 2015
@KrzysztofCwalina KrzysztofCwalina removed their assignment Sep 23, 2016
@ahsonkhan ahsonkhan added this to the 2.1.0 milestone Apr 6, 2017
@joshfree joshfree changed the title Write more perfromance tests and optimize runtime perfromance Write more performance tests and optimize runtime performance Apr 5, 2018
@joshfree joshfree modified the milestones: 2.1.0, Future Apr 5, 2018
@GrabYourPitchforks
Copy link
Member

@KrzysztofCwalina What remains to be done here? The formatters / parsers are now productized and the RTM code appears to have addressed much of these concerns.

@pgovind pgovind added the OpenBeforeArchiving These issues were open before the repo was archived. For re-open them, file them in the new repo label Mar 11, 2021
@pgovind pgovind closed this as completed Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Formatting OpenBeforeArchiving These issues were open before the repo was archived. For re-open them, file them in the new repo up-for-grabs
Projects
None yet
Development

No branches or pull requests

5 participants