Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

ILVerify: split into exe and library #5258

Merged
merged 4 commits into from
Jan 18, 2018
Merged

ILVerify: split into exe and library #5258

merged 4 commits into from
Jan 18, 2018

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Jan 18, 2018

Per discussion in #5235, the library code and corresponding tests go into src/ILVerification, while the command-line exe is produced from src/ILVerify.

I kept a single solution (under ILVerify) which points to the three projects.

Aside from solution and project file changes, the code changes were:

  • Program.cs was removed from ILVerification and moved to ILVerify.
  • The resource file for ILVerification changed name.
  • Added some InternalsVisibleTo to ILVerify.

Fixes #5235
Relates to dotnet/roslyn#22872

Tagging @jkotas @ArztSamuel @A-And

@jcouv jcouv self-assigned this Jan 18, 2018
@jcouv
Copy link
Member Author

jcouv commented Jan 18, 2018

Hum, it looks like I need to work on the command-line build, as CI produced:
D:\j\workspace\release_windo---c2468dc6\dir.traversal.targets(24,5): error : (No message specified) [D:\j\workspace\release_windo---c2468dc6\src\dirs.proj]

@ArztSamuel
Copy link
Collaborator

LGTM!

Out of personal interest: Do you think it would be a desirable goal to change the code at some point, to only rely on the public interface without having to expose internals to both ILVerify and the Tests projects?

@jkotas
Copy link
Member

jkotas commented Jan 18, 2018

Do you think it would be a desirable goal to change the code at some point, to only rely on the public interface without having to expose internals to both ILVerify and the Tests projects?

Yes, it would be definitely a desirable goal.

@@ -0,0 +1,3 @@
# ILVerification

The ILVerification library is part of the ILVerify project. See details under [src/ILVerify/](https://github.com/dotnet/corert/tree/master/src/ILVerify).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It would be nice to use relative URLs for the relative tree links so that the links stay valid when the repo is forked or branched.

@jkotas jkotas merged commit eb2f375 into dotnet:master Jan 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants