Fix auth for certain types and finish adoption latest Azure SDK #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran the daily pipeline using this branch to vet the changes. The build succeeds while the main branch fails: https://dev.azure.com/dnceng/internal/_build/results?buildId=2490918&view=results |
|
Commit b1a6c3f is the auth fix. The rest are SDK updates. |
dougbu
previously approved these changes
Jul 9, 2024
src/SecretManager/Microsoft.DncEng.SecretManager.ScenarioTests/ServiceBusTests.cs
Outdated
Show resolved
Hide resolved
src/SecretManager/Microsoft.DncEng.SecretManager.ScenarioTests/ServiceBusTests.cs
Outdated
Show resolved
Hide resolved
src/SecretManager/Microsoft.DncEng.SecretManager.ScenarioTests/StorageTests.cs
Outdated
Show resolved
Hide resolved
src/SecretManager/Microsoft.DncEng.SecretManager.ScenarioTests/ScenarioTestsBase.cs
Show resolved
Hide resolved
src/SecretManager/Microsoft.DncEng.SecretManager/SecretTypes/AzureStorageBlobSasUri.cs
Show resolved
Hide resolved
src/SecretManager/Microsoft.DncEng.SecretManager/SecretTypes/AzureStorageContainerSasUri.cs
Show resolved
Hide resolved
dougbu
approved these changes
Jul 9, 2024
This was referenced Jul 9, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/dnceng#3301
This PR has two main components:
The later change is necessary because secretless authentication configurations are now complex enough that the defaults are not good enough. It will resolve the ongoing failures we've seen lately with rotations.