Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display C# special types using familiar format #8372

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Jan 28, 2023

Addresses #5599

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Jan 28, 2023
@yufeih yufeih force-pushed the feature/specialtypes branch 2 times, most recently from 8c68ad5 to 1e6f9d5 Compare January 28, 2023 04:26
@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Base: 76.64% // Head: 76.66% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (0738883) compared to base (f34abfb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8372      +/-   ##
==========================================
+ Coverage   76.64%   76.66%   +0.02%     
==========================================
  Files         940      940              
  Lines       35281    35281              
==========================================
+ Hits        27040    27048       +8     
+ Misses       8241     8233       -8     
Impacted Files Coverage Δ
...etadata.ManagedReference.Roslyn/SymbolFormatter.cs 100.00% <100.00%> (+1.09%) ⬆️
...dReference.Roslyn/Visitors/CSYamlModelGenerator.cs 100.00% <100.00%> (ø)
...dReference.Roslyn/Visitors/VBYamlModelGenerator.cs 100.00% <100.00%> (ø)
....ManagedReference.Roslyn/Visitors/VisitorHelper.cs 90.00% <100.00%> (ø)
...osoft.DocAsCode.Tests.Common/TestLoggerListener.cs 94.33% <0.00%> (+1.88%) ⬆️
src/Microsoft.DocAsCode.Common/Git/GitUtility.cs 78.19% <0.00%> (+3.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih force-pushed the feature/specialtypes branch 3 times, most recently from 6caa203 to 571c140 Compare January 29, 2023 02:04
@yufeih yufeih merged commit 6458702 into main Jan 30, 2023
@yufeih yufeih deleted the feature/specialtypes branch January 30, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant