Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make _tocRel deterministic #9483

Merged
merged 4 commits into from
Nov 27, 2023
Merged

fix: make _tocRel deterministic #9483

merged 4 commits into from
Nov 27, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Nov 27, 2023

When both toc.html.tmpl and toc.json.tmpl appear in template, the output extension is indeterministic. Renaming toc.html.tmpl to toc.html.primary.tmpl ensures we use the html extension.

Fixes #9479

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Nov 27, 2023
@yufeih yufeih marked this pull request as ready for review November 27, 2023 13:12
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf5fdea) 71.36% compared to head (7e1e862) 71.37%.

❗ Current head 7e1e862 differs from pull request most recent head c2805eb. Consider uploading reports for the commit c2805eb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9483      +/-   ##
==========================================
+ Coverage   71.36%   71.37%   +0.01%     
==========================================
  Files         558      558              
  Lines       24028    24028              
  Branches     4185     4185              
==========================================
+ Hits        17148    17151       +3     
+ Misses       5784     5782       -2     
+ Partials     1096     1095       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filzrev
Copy link
Contributor

filzrev commented Nov 27, 2023

Renaming toc.html.tmpl to toc.html.primary.tmpl ensures we use the html extension.

pdf.default template also contains these file names.
It might needs to rename these files.

@yufeih yufeih closed this Nov 27, 2023
@yufeih yufeih reopened this Nov 27, 2023
@yufeih yufeih merged commit 8f76702 into main Nov 27, 2023
8 checks passed
@yufeih yufeih deleted the fix-toc-rel branch November 27, 2023 14:03
joelhulen added a commit to joelhulen/SingulinkFX that referenced this pull request Dec 15, 2023
The latest version of Docfx has a breaking change, requiring the renaming of this file. Reference: dotnet/docfx#9483
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My sidebar is broken, docfx:navrel and docfx:tocrel are wrong
2 participants