Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code copy not shown on collapsed divs #9531

Merged
merged 4 commits into from
Dec 18, 2023
Merged

fix: code copy not shown on collapsed divs #9531

merged 4 commits into from
Dec 18, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Dec 15, 2023

Fixes #9517

https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/innerText

Note: innerText is easily confused with Node.textContent, but there are important differences between the two. Basically, innerText is aware of the rendered appearance of text, while textContent is not.

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84b7afb) 71.37% compared to head (5b22bb7) 71.37%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9531   +/-   ##
=======================================
  Coverage   71.37%   71.37%           
=======================================
  Files         558      558           
  Lines       24024    24024           
  Branches     4173     4173           
=======================================
  Hits        17147    17147           
  Misses       5780     5780           
  Partials     1097     1097           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih closed this Dec 15, 2023
@yufeih yufeih reopened this Dec 15, 2023
@yufeih yufeih closed this Dec 18, 2023
@yufeih yufeih reopened this Dec 18, 2023
@yufeih yufeih merged commit a9bc8c6 into main Dec 18, 2023
7 checks passed
@yufeih yufeih deleted the fix-code-copy branch December 18, 2023 02:19
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
* fix: code copy not shown on collapsed divs

* test(snapshot): update snapshots 5395cd4 for ubuntu-latest

* test(snapshot): update snapshots 5395cd4 for windows-latest

* test(snapshot): update snapshots ce224c8 for ubuntu-latest

---------

Co-authored-by: yufeih <yufeih@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not detect code section in nested object
1 participant