Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new submodule format using .git file #9540

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Support new submodule format using .git file #9540

merged 1 commit into from
Dec 18, 2023

Conversation

georghinkel
Copy link
Contributor

Addresses #9538

@georghinkel
Copy link
Contributor Author

@dotnet-policy-service agree

yufeih
yufeih approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you @georghinkel !

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Dec 18, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (2dd7f20) 71.36% compared to head (2083762) 71.36%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/Docfx.Common/Git/GitUtility.cs 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9540   +/-   ##
=======================================
  Coverage   71.36%   71.36%           
=======================================
  Files         558      558           
  Lines       24024    24031    +7     
  Branches     4173     4176    +3     
=======================================
+ Hits        17144    17150    +6     
  Misses       5782     5782           
- Partials     1098     1099    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih merged commit 4252c0f into dotnet:main Dec 18, 2023
7 checks passed
@filzrev filzrev mentioned this pull request Dec 18, 2023
Closed
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
@georghinkel @p-kostov
Support new submodule format using .git file (dotnet#9540)
029f69d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufeih yufeih yufeih approved these changes

Assignees
No one assigned
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georghinkel @yufeih