Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't open search links in a new window/tab #956

Closed
wants to merge 1 commit into from

Conversation

pascalberger
Copy link
Member

Don't open search links in a new window/tab.

If there's a possibility to access settings from docfx.json in the docfx.js file I could also implement it as a metadata switch.

Please also mention if you expect a test case for this.

#227

@dnfclas
Copy link

dnfclas commented Dec 5, 2016

Hi @pascalberger, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@qinezh
Copy link
Contributor

qinezh commented Dec 5, 2016

Just like @lidermanrony said in #227 , how could you resolve the issue that the back
button doesn't return you to search results after you clicked on a link in this way?

@pascalberger
Copy link
Member Author

@qinezh That's a valid point and with the current implementation of the client search I don't see any quick workaround. Will close this PR as a consequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants