Update webbrowser sample #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per suggestions dotnet/winforms#4443 (comment) Resolves dotnet/winforms#4443
|
May I please get guidance on how to fix the build failure? |
adegeo
reviewed
Jan 18, 2021
...-desktop-guide/framework/winforms/controls/implement-two-way-com-between-dhtml-and-client.md
Outdated
Show resolved
Hide resolved
|
@RussKie These samples were written before we had compile testing. Now that we do, we just need a project file in the same folder as the code so that the code will be compiled. |
|
Thanks, I added project files, but the NuGet config seems busted. |
adegeo
reviewed
Jan 25, 2021
...-desktop-guide/framework/winforms/controls/implement-two-way-com-between-dhtml-and-client.md
Outdated
Show resolved
Hide resolved
|
@RussKie our testing system was installing a preview build of .net 5 and that caused the nuget restores to fail because they couldn't find preview packages on nuget. We fixed this last week. I closed/opened your PR and the build is passing. We just need @KlausLoeffelmann to hit up the VB code and we can merge! |
…-way-com-between-dhtml-and-client.md Co-authored-by: Andy De George <67293991+adegeo@users.noreply.github.com>
adegeo
approved these changes
Jan 27, 2021
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Correct the "How to: Implement Two-Way Communication Between DHTML Code and Client Application Code" sample as per suggestions dotnet/winforms#4443 (comment).
Resolves dotnet/winforms#4443
@KlausLoeffelmann may I get you to check the VB code?
/cc: @gewarren