Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document a few new SDK properties customers affecting Maui and xplat compilation #30076

Closed
marcpopMSFT opened this issue Jul 1, 2022 · 4 comments · Fixed by #31967
Closed
Assignees
Labels
🏁 Release: .NET 7 Work items for the .NET 7 release doc-enhancement Improve the current content [org][type][category] Pri1 High priority, do before Pri2 and Pri3

Comments

@marcpopMSFT
Copy link
Member

marcpopMSFT commented Jul 1, 2022

Help us make content visible

DisableTransitiveFrameworkReferenceDownloads
Microsoft.Maui.Essentials
EnableWindowsTargeting
NETSDK1100

Describe the new article

@tdykstra, this PR makes three changes we want documentation on: dotnet/sdk#25358

  1. If a customer wants to build a windows application (WPF, Winforms) on a non-windows platform, they will get NETSDK1100 today. We've changed the behavior so that if they set <EnableWindowsTargeting>true</EnableWindowsTargeting>, this will enable them to get unblocked. This is because we don't automatically download targeting and runtime packs on platforms that aren't supported but with this flag, we now will when cross-targeting.
  2. If a customer has a reference to a project that uses Maui essentials but haven't set <UseMauiEssentials>true</UseMauiEssentials>, then they will need to. We can't flow the maui essentially dependencies automatically without breaking other scenarios but setting this will make sure that the referencing project correctly pulls in the right known framework reference for maui essentialls.
  3. We added DisableTransitiveFrameworkReferenceDownloads. Setting this to true will let customers avoid downloading extra runtime and targeting packs they didn't need. For some Maui windows scenarios, it was trying to download aspnet and windows desktop packages just in case they were needed later and this will disable that unless directly used.
@PRMerger3 PRMerger3 added the Pri3 label Jul 1, 2022
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Jul 1, 2022
@marcpopMSFT
Copy link
Member Author

CC @dsplaisted to review this when the documentation is ready.

@tdykstra tdykstra self-assigned this Jul 12, 2022
@tdykstra tdykstra added doc-enhancement Improve the current content [org][type][category] Pri1 High priority, do before Pri2 and Pri3 and removed Pri3 labels Jul 12, 2022
@tdykstra tdykstra removed the ⌚ Not Triaged Not triaged label Jul 19, 2022
@gewarren gewarren assigned gewarren and unassigned tdykstra Jul 21, 2022
@gewarren
Copy link
Contributor

@marcpopMSFT @dsplaisted For UseMauiEssentials, it seems that the namespaces are no longer named "Maui.Essentials" - dotnet/maui#5562 (comment). Did/should the property name change too?

@gewarren gewarren added the 🏁 Release: .NET 7 Work items for the .NET 7 release label Oct 21, 2022
@ghost ghost added the in-pr This issue will be closed (fixed) by an active pull request. label Oct 21, 2022
@dsplaisted
Copy link
Member

@marcpopMSFT @dsplaisted For UseMauiEssentials, it seems that the namespaces are no longer named "Maui.Essentials" - dotnet/maui#5562 (comment). Did/should the property name change too?

@Redth @jonathanpeppers Can you comment on this?

@jonathanpeppers
Copy link
Member

I've found DisableTransitiveFrameworkReferenceDownloads is needed sometimes.

Errors like this for an Android project:

Unable to find package Microsoft.WindowsDesktop.App.Runtime.win-x64 with version (= 7.0.0)

Which is probably caused by stable branding/feeds changing. This was noticied on the https://aka.ms/dotnetperfstatus pipelines that build MAUI projects and measure performance.

But then a customer wouldn't hit this? Just dogfooders, and internal pipelines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Release: .NET 7 Work items for the .NET 7 release doc-enhancement Improve the current content [org][type][category] Pri1 High priority, do before Pri2 and Pri3
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants