Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit pass on install-scripts #35766

Closed
tdykstra opened this issue Jun 13, 2023 · 2 comments · Fixed by #36481
Closed

Edit pass on install-scripts #35766

tdykstra opened this issue Jun 13, 2023 · 2 comments · Fixed by #36481
Assignees
@tdykstra
Labels
cli/subsvc doc-enhancement Improve the current content [org][type][category] dotnet-fundamentals/svc Pri1 High priority, do before Pri2 and Pri3 resolved-by-customer Indicates issues where the customer no longer needs any help. [org][resolution]

Comments

@tdykstra
Copy link
Contributor

See conversation at https://github.com/dotnet/docs/pull/35752/files#r1226843449

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
@tdykstra tdykstra self-assigned this Jun 13, 2023
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Jun 13, 2023
@issues-automation issues-automation bot added dotnet-fundamentals/svc Pri1 High priority, do before Pri2 and Pri3 labels Jun 13, 2023
@tdykstra tdykstra added the doc-enhancement Improve the current content [org][type][category] label Jun 13, 2023
@dotnet-bot dotnet-bot removed the ⌚ Not Triaged Not triaged label Jun 13, 2023
@tdykstra tdykstra mentioned this issue Jun 13, 2023
Merged
@IEvangelist
Copy link
Member

Hey @tdykstra - should this have been closed as a result of #35752 too?

@tdykstra
Copy link
Contributor Author

tdykstra commented Jun 14, 2023 •
edited
Loading

No, this was opened as a result of 35752. We didn't do your list reformat suggestion using colons because other lists in the doc used the hyphen format and so the lists would have been inconsistent. I can use this issue to go through and make all lists use the colon format plus address any other style issues in the text.

@tdykstra tdykstra mentioned this issue Aug 1, 2023
Merged
@ghost ghost added the in-pr This issue will be closed (fixed) by an active pull request. label Aug 1, 2023
@dotnet-bot dotnet-bot added the resolved-by-customer Indicates issues where the customer no longer needs any help. [org][resolution] label Aug 2, 2023
@ghost ghost removed the in-pr This issue will be closed (fixed) by an active pull request. label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdykstra tdykstra

Labels
cli/subsvc doc-enhancement Improve the current content [org][type][category] dotnet-fundamentals/svc Pri1 High priority, do before Pri2 and Pri3 resolved-by-customer Indicates issues where the customer no longer needs any help. [org][resolution]
Projects
No open projects
dotnet/docs August 2023 sprint
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Edit pass tdykstra/dotnet-docs
3 participants
@tdykstra @IEvangelist @dotnet-bot