Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main into live #36469

Merged
merged 12 commits into from
Aug 1, 2023
Merged

Merge main into live #36469

merged 12 commits into from
Aug 1, 2023

Commits on Jul 31, 2023

  1. Update coding guidelines (#36428) 

    * rearrange content

Make the new content organization follow better ordering.

* rewrite and update

Rewrite to match the docs team's accepted style.

* Edits to fix `var` issues

Fixes #26787: clarify "obvious"
Fixes #32633: add explanation, update variable names.
Fixes #34940: Explain that `var` is preferred in LINQ queries, despite other rules.

* Fix naming conventions

Fixes #30626: Clarify (again) that these are our guidelines, not yours. Point out that it's not the VS default, but a configuration option.
Fixes #30642: Again, our style.
Fixes #30799: Change constant style from ALL_CAPS to PascalCase to match runtime repo.
Fixes #33959: Update variable names so delegate types are PascalCased and instances of a delegate are camelCase. Add clarifying text for the same.

* Fix exception example

Fixes #31951 : Rewrite the exception example so that it's still obvious what can fail, but couldn't be easily anticipated before making the computation.

* Fixes #30897

Move the Generic type parameter naming conventions to the general naming conventions.

* Fix build warnings

* Reference runtime convention

The use of `_` and `s_` follow the runtime conventions. I'd missed that in the previous commit.

* Apply suggestions from code review

Co-authored-by: David Pine <david.pine@microsoft.com>

---------

Co-authored-by: David Pine <david.pine@microsoft.com>
    @BillWagner @IEvangelist
    BillWagner and IEvangelist committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    49d553f View commit details
    Browse the repository at this point in the history

  2. Update using-delegates.md (#36455) 

    Fixes #36454
    @IEvangelist
    IEvangelist committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    183f2ec View commit details
    Browse the repository at this point in the history

  3. Make actions and funcs local (#36458) 

    See #36428 (comment)

For the issue involved, it's a better fix to create local variables for the Func and Action objects. That shows readers the distinction between the delegate type and the instance.
    @BillWagner
    BillWagner committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    fd56aa8 View commit details
    Browse the repository at this point in the history

  4. Container tag breaking change (#36433)

    @gewarren
    gewarren committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    b155ced View commit details
    Browse the repository at this point in the history

  5. Tool manifest breaking change (#36447)

    @gewarren
    gewarren committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    29438dc View commit details
    Browse the repository at this point in the history

  6. Update index.md (#36457) 

    Fixes #36451
    @IEvangelist
    IEvangelist committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    99633b7 View commit details
    Browse the repository at this point in the history

  7. Update database-errors.md (#36456) 

    Fixes #36453
    @IEvangelist
    IEvangelist committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    52882a7 View commit details
    Browse the repository at this point in the history

  8. Update package index with latest published versions (#36460)

    @azure-sdk
    azure-sdk committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    a92a088 View commit details
    Browse the repository at this point in the history

  9. Add docs for CA1865/CA1866/CA1867 (#36417)

    @mrahhal
    mrahhal committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    197f228 View commit details
    Browse the repository at this point in the history

  10. Update prepare-libraries-for-trimming.md (#36414) 

    * Update prepare-libraries-for-trimming.md

Update to .NET 8

* Update prepare-libraries-for-trimming.md

* Update prepare-libraries-for-trimming.md

Remove horizontal scroll bar on tablets

* Update prepare-libraries-for-trimming.md
    @Rick-Anderson
    Rick-Anderson committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    8e4994f View commit details
    Browse the repository at this point in the history

  11. Update package index with latest published versions (#36461)

    @azure-sdk
    azure-sdk committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    0b1bd2c View commit details
    Browse the repository at this point in the history

  12. Update package index with latest published versions (#36464)

    @azure-sdk
    azure-sdk committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    a6f103c View commit details
    Browse the repository at this point in the history