Update sample.cs #8740
Merged
Update sample.cs #8740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor cleanup: * In `Handle` setter, remove `else`. * In both the constructor and `Load` method, rename `Path` to `path`. * Deleted comment in setter explaining how if the handle is valid, return the handle value. * Got rid of brackets for if-statements with 1 line. * Changed constructor to be expression-bodied. * Deleted some unnecessary empty lines. There's a good amount that could change for this example. One more thing: I came here to fix an error in the `Load` method as it appears in [MSDN](https://learn.microsoft.com/en-us/dotnet/api/microsoft.win32.safehandles.safefilehandle?view=net-7.0) (`&&` should be `||`). That is actually fixed here but the change hasn't been reflected in the site. Does something need to be triggered for this to happen?
ghost
added
the
community-contribution
|
|
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Learn Build status updates of commit 3c8005e: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Learn Build status updates of commit 3c8005e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minor cleanup:
Handlesetter, removedelse.Loadmethod, renamedPathtopath.There's a good amount more that could change for this example.
If approved, I'll apply these changes to the snippet for SafeWaitHandle too.