Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting new docs for the System.Numerics namespace #9165

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

tannergooding
Copy link
Member

This handles most of dotnet/runtime#88570. There are some APIs that are missing xml docs entirely that still need to be handled.

@ghost
Copy link

ghost commented Jul 25, 2023

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

This handles most of dotnet/runtime#88570. There are some APIs that are missing xml docs entirely that still need to be handled.

Author: tannergooding
Assignees: tannergooding
Labels:

area-System.Numerics

Milestone: -

@learn-build-service-prod
Copy link

Learn Build status updates of commit c49f9d5:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Numerics/BigInteger.xml ✅Succeeded View
xml/System.Numerics/BitOperations.xml ✅Succeeded View
xml/System.Numerics/Complex.xml ✅Succeeded View
xml/System.Numerics/IFloatingPointIeee754`1.xml ✅Succeeded View
xml/System.Numerics/TotalOrderIeee754Comparer`1.xml ✅Succeeded View
xml/System.Numerics/Vector.xml ✅Succeeded View
xml/System.Numerics/Vector`1.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 22ed684:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Numerics/BigInteger.xml ✅Succeeded View
xml/System.Numerics/BitOperations.xml ✅Succeeded View
xml/System.Numerics/Complex.xml ✅Succeeded View
xml/System.Numerics/IFloatingPointIeee754`1.xml ✅Succeeded View
xml/System.Numerics/TotalOrderIeee754Comparer`1.xml ✅Succeeded View
xml/System.Numerics/Vector.xml ✅Succeeded View
xml/System.Numerics/Vector`1.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for you to consider.

xml/System.Numerics/BigInteger.xml Outdated Show resolved Hide resolved
xml/System.Numerics/BigInteger.xml Outdated Show resolved Hide resolved
xml/System.Numerics/BitOperations.xml Outdated Show resolved Hide resolved
xml/System.Numerics/BitOperations.xml Outdated Show resolved Hide resolved
xml/System.Numerics/BitOperations.xml Outdated Show resolved Hide resolved
xml/System.Numerics/BitOperations.xml Outdated Show resolved Hide resolved
xml/System.Numerics/Complex.xml Outdated Show resolved Hide resolved
xml/System.Numerics/Complex.xml Outdated Show resolved Hide resolved
xml/System.Numerics/Complex.xml Outdated Show resolved Hide resolved
xml/System.Numerics/Complex.xml Outdated Show resolved Hide resolved
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
@learn-build-service-prod
Copy link

Learn Build status updates of commit b60f531:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Numerics/BigInteger.xml ✅Succeeded View
xml/System.Numerics/BitOperations.xml ✅Succeeded View
xml/System.Numerics/Complex.xml ✅Succeeded View
xml/System.Numerics/IFloatingPointIeee754`1.xml ✅Succeeded View
xml/System.Numerics/TotalOrderIeee754Comparer`1.xml ✅Succeeded View
xml/System.Numerics/Vector.xml ✅Succeeded View
xml/System.Numerics/Vector`1.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 74dd58e:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Numerics/BigInteger.xml ✅Succeeded View
xml/System.Numerics/BitOperations.xml ✅Succeeded View
xml/System.Numerics/Complex.xml ✅Succeeded View
xml/System.Numerics/IFloatingPointIeee754`1.xml ✅Succeeded View
xml/System.Numerics/TotalOrderIeee754Comparer`1.xml ✅Succeeded View
xml/System.Numerics/Vector.xml ✅Succeeded View
xml/System.Numerics/Vector`1.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@carlossanlop carlossanlop enabled auto-merge (squash) July 27, 2023 14:33
@carlossanlop carlossanlop merged commit 663c473 into dotnet:main Jul 27, 2023
2 checks passed
@tannergooding tannergooding deleted the runtime-88570 branch July 27, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants