Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that Assembly.Load[File/From] throwing on remote only applies to .NET Framework #9911

Merged
merged 6 commits into from
May 14, 2024

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented May 14, 2024

Summary

The Assembly.Load[File/From] docs indicate that they throw FileLoadException on .NET Framework 4 and later for remote assemblies/paths. This is confusing as it can be interpreted as applying to .NET Core/5+, which does not do this.

  • Replace comments about remote assemblies with link to which has more accurate information
  • For the overloads that exist in .NET Core/5+, to specify that behaviour is .NET Framework only

cc @AaronRobinsonMSFT @GrabYourPitchforks

@AaronRobinsonMSFT
Copy link
Member

/cc @gewarren

Copy link

Learn Build status updates of commit 7b0a91a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection/Assembly.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit e267603:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
xml/System.Reflection/Assembly.xml ❌Error Details

  • Line 0, Column 0: [Error: ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...

xml/System.Reflection/Assembly.xml

  • Line 0, Column 0: [Error: ECMA2Yaml_InternalError]
Intenal Several Error: System.Xml.XmlException: The 'exception' start tag on line 4334 position 10 does not match the end tag of 'Docs'. Line 4341, position 9.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
   at System.Xml.XmlTextReaderImpl.ThrowTagMismatch(NodeData startTag)
   at System.Xml.XmlTextReaderImpl.ParseEndElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

Learn Build status updates of commit fc9dd2a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection/Assembly.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

xml/System.Reflection/Assembly.xml Outdated Show resolved Hide resolved
xml/System.Reflection/Assembly.xml Outdated Show resolved Hide resolved
xml/System.Reflection/Assembly.xml Show resolved Hide resolved
xml/System.Reflection/Assembly.xml Outdated Show resolved Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Copy link

Learn Build status updates of commit 22c7d1d:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection/Assembly.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 0aec188:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection/Assembly.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@elinor-fung elinor-fung merged commit 5a7ae0a into dotnet:main May 14, 2024
3 checks passed
@elinor-fung elinor-fung deleted the assembly-load-remote branch May 14, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants